Skip to content

fix(docs): stop showing both demo terminal images at once - #304

Merged
oekazuma merged 1 commit into
mainfrom
fix/demo-terminal-duplicate-images
Jul 24, 2026
Merged

oekazuma merged 1 commit into
mainfrom
fix/demo-terminal-duplicate-images

Conversation

@oekazuma

@oekazuma oekazuma commented Jul 24, 2026 •

Copy link
Copy Markdown
Owner

Summary

Regression from #303 (currently live in production): the homepage demo terminal shows both the animated GIF and the static poster image stacked on top of each other.

Root cause: #303 added display: block to the shared .demo-terminal img selector to fix a white-gap bug. That selector's specificity (.demo-terminal img = 0-1-1) is higher than .demo-gif-static's (0-1-0), so it silently overrode display: none on the static poster — both images render simultaneously instead of just the animated one.

Fix: drop display: block from the shared rule. .demo-gif-animated already sets display: block on its own (same specificity as .demo-gif-static, but they're mutually exclusive classes on different elements, so no conflict), and .demo-gif-static's display: none is no longer overridden.

Test plan

  • Verified via blume dev in both light and dark mode: only one image renders in each case, no white gap regression
  • pnpm lint passes

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Style
    • Adjusted demo terminal image styling on the documentation pages.
    • Removed the block display setting while preserving existing sizing and spacing.

#303's fix added display:block to the shared .demo-terminal img
selector to fix a white-gap bug. That selector's specificity
(.demo-terminal img = 0-1-1) is higher than .demo-gif-static's
(0-1-0), so it overrode display:none on the static poster image —
both the animated GIF and the static poster rendered simultaneously,
stacked. Drop display:block from the shared rule; .demo-gif-animated
already sets it on its own, and .demo-gif-static's display:none is no
longer overridden.

Verified in both light and dark mode via blume dev: only one image
renders in each case.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 24, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 976673dc-d8b6-4ed3-8701-d7d588d686d3

📥 Commits

Reviewing files that changed from the base of the PR and between b5521ff and bb4a0d6.

📒 Files selected for processing (2)
  • docs/src/content/docs/index.mdx
  • docs/src/content/docs/ja/index.mdx
💤 Files with no reviewable changes (2)
  • docs/src/content/docs/ja/index.mdx
  • docs/src/content/docs/index.mdx

📝 Walkthrough

Walkthrough

The English and Japanese documentation pages remove display: block; from the inline .demo-terminal img CSS rule. The existing width: 100% and margin: 0 declarations remain unchanged.

Changes

Demo terminal image styling

Layer / File(s) Summary
Update demo terminal CSS
docs/src/content/docs/index.mdx, docs/src/content/docs/ja/index.mdx
The .demo-terminal img rule no longer sets display: block;; its width and margin declarations remain.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main docs fix: preventing the demo terminal’s static and animated images from both showing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@oekazuma
oekazuma merged commit b4e0bfb into main Jul 24, 2026
7 checks passed
@oekazuma
oekazuma deleted the fix/demo-terminal-duplicate-images branch July 24, 2026 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant