Repository navigation
fix(docs): stop showing both demo terminal images at once - #304
Merged
Merged
Conversation
#303's fix added display:block to the shared .demo-terminal img selector to fix a white-gap bug. That selector's specificity (.demo-terminal img = 0-1-1) is higher than .demo-gif-static's (0-1-0), so it overrode display:none on the static poster image — both the animated GIF and the static poster rendered simultaneously, stacked. Drop display:block from the shared rule; .demo-gif-animated already sets it on its own, and .demo-gif-static's display:none is no longer overridden. Verified in both light and dark mode via blume dev: only one image renders in each case. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThe English and Japanese documentation pages remove ChangesDemo terminal image styling
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regression from #303 (currently live in production): the homepage demo terminal shows both the animated GIF and the static poster image stacked on top of each other.
Root cause: #303 added
display: blockto the shared.demo-terminal imgselector to fix a white-gap bug. That selector's specificity (.demo-terminal img= 0-1-1) is higher than.demo-gif-static's (0-1-0), so it silently overrodedisplay: noneon the static poster — both images render simultaneously instead of just the animated one.Fix: drop
display: blockfrom the shared rule..demo-gif-animatedalready setsdisplay: blockon its own (same specificity as.demo-gif-static, but they're mutually exclusive classes on different elements, so no conflict), and.demo-gif-static'sdisplay: noneis no longer overridden.Test plan
blume devin both light and dark mode: only one image renders in each case, no white gap regressionpnpm lintpasses🤖 Generated with Claude Code
Summary by CodeRabbit