[new release] domain-name (0.3.1)#19881
Merged
Merged
Conversation
Member
|
I think a loooot of packages were getting astring transitively from this :D |
Member
|
Probably via awa, looking at a number of the failures: https://github.com/mirage/awa-ssh/blob/200091e42500f79f4ccb399ac685987638be64af/lib/keys.ml#L56 |
Member
Author
|
Yes, and fmt as well. I'm not sure how to handle this, I'd like the CI to not have to rerun all the jobs. Also, I suspect some reverse dependencies are not tested in the CI (since they're not available on 4.13 -- looking at you tezos>7). |
Member
|
I think we should add an upper bound in awa and tezos as separate PRs, then rebase this one |
Member
Author
mseri
added a commit
that referenced
this pull request
Oct 27, 2021
It currently uses `fmt`, which is obtained transitively via some dependency which, in turns, depends on `domain-name-conflict`. Seen on: #19881 (comment)
Member
Author
mseri
added a commit
that referenced
this pull request
Oct 27, 2021
* tezos-stdlib-unix: add domain-name conflict It currently uses `fmt`, which is obtained transitively via some dependency which, in turns, depends on `domain-name-conflict`. Seen on: #19881 (comment) * Tezos-stdlib-uniz.7m*: suggestions from code review Co-authored-by: Hannes Mehnert <hannes@mehnert.org> * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Hannes Mehnert <hannes@mehnert.org> Co-authored-by: Hannes Mehnert <hannes@mehnert.org>
Member
|
All merged, this cannow be rebased and tested |
CHANGES: * remove fmt and astring dependency
hannesm
force-pushed
the
release-domain-name-v0.3.1
branch
from
5f0500a to
c2ab99f
Compare
Member
Author
|
thanks @mseri, rebased and force-pushed. |
Member
Author
|
this looks good to be merged. |
fdopen
added a commit
to fdopen/opam-repository-mingw
that referenced
this pull request
Nov 1, 2021
* tezos-stdlib-unix: add domain-name conflict It currently uses `fmt`, which is obtained transitively via some dependency which, in turns, depends on `domain-name-conflict`. Seen on: ocaml/opam-repository#19881 (comment) * Tezos-stdlib-uniz.7m*: suggestions from code review Co-authored-by: Hannes Mehnert <hannes@mehnert.org> * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Hannes Mehnert <hannes@mehnert.org> Co-authored-by: Hannes Mehnert <hannes@mehnert.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 1035 Internet domain names
CHANGES: