awa, dkim, paf-le: restrict to domain-name that depend on astring#19886
Merged
Conversation
hannesm
changed the title
Member
Author
|
//cc @dinosaure dkim uses Astring without declaring that as dependency -- here I restrict it to domain-name before domain-name removed nearly all dependencies ;) |
hannesm
changed the title
Member
Author
|
/cc @dinosaure for paf-le (0.0.6) -- also has an implicit astring dependency |
Member
Author
|
this looks good to be merged. |
kit-ty-kate
reviewed
Oct 29, 2021
| "base64" {>= "3.0.0"} | ||
| "hacl_x25519" {>= "0.2.0"} | ||
| "zarith" | ||
| "domain-name" {< "0.3.1"} |
Member
There was a problem hiding this comment.
why has domain-name been added here? I'm not seeing it in the explicit dependencies
Member
Author
There was a problem hiding this comment.
would instead a conflicts: domain-name >= 0.3.1 suit you better? I can open a PR if you like.
Member
Author
There was a problem hiding this comment.
see #19902 - applying conflict instead of a dependency with an upper bound
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
//cc @mseri as discussed in #19881