Skip to content

tezos-stdlib-unix: add domain-name conflict#19888

Merged
mseri merged 4 commits into
masterfrom
patch-tezos
Oct 27, 2021
Merged

tezos-stdlib-unix: add domain-name conflict#19888
mseri merged 4 commits into
masterfrom
patch-tezos

Conversation

@mseri
Copy link
Copy Markdown
Member

@mseri mseri commented Oct 27, 2021

It currently uses fmt, which is obtained transitively via some dependency which, in turns, depends on domain-name-conflict.

Seen on: #19881 (comment)

It currently uses `fmt`, which is obtained transitively via some dependency which, in turns, depends on `domain-name-conflict`.

Seen on: #19881 (comment)
Comment thread packages/tezos-stdlib-unix/tezos-stdlib-unix.7.0/opam Outdated
Comment thread packages/tezos-stdlib-unix/tezos-stdlib-unix.7.1/opam Outdated
Comment thread packages/tezos-stdlib-unix/tezos-stdlib-unix.7.2/opam Outdated
Comment thread packages/tezos-stdlib-unix/tezos-stdlib-unix.7.3/opam Outdated
Comment thread packages/tezos-stdlib-unix/tezos-stdlib-unix.7.4/opam Outdated
Co-authored-by: Hannes Mehnert <hannes@mehnert.org>
@mseri
Copy link
Copy Markdown
Member Author

mseri commented Oct 27, 2021

Indeed, thanks a lot!

Comment thread packages/tezos-stdlib-unix/tezos-stdlib-unix.7.0/opam
Comment thread packages/tezos-stdlib-unix/tezos-stdlib-unix.7.1/opam
Comment thread packages/tezos-stdlib-unix/tezos-stdlib-unix.7.2/opam
Comment thread packages/tezos-stdlib-unix/tezos-stdlib-unix.7.3/opam
Comment thread packages/tezos-stdlib-unix/tezos-stdlib-unix.7.4/opam
Comment thread packages/tezos-stdlib-unix/tezos-stdlib-unix.7.0/opam
Comment thread packages/tezos-stdlib-unix/tezos-stdlib-unix.7.1/opam
Comment thread packages/tezos-stdlib-unix/tezos-stdlib-unix.7.2/opam
Comment thread packages/tezos-stdlib-unix/tezos-stdlib-unix.7.3/opam
Comment thread packages/tezos-stdlib-unix/tezos-stdlib-unix.7.4/opam
Co-authored-by: Hannes Mehnert <hannes@mehnert.org>
@mseri
Copy link
Copy Markdown
Member Author

mseri commented Oct 27, 2021

Thanks

@mseri mseri merged commit 1bc4766 into master Oct 27, 2021
@mseri mseri deleted the patch-tezos branch October 27, 2021 21:29
@kit-ty-kate
Copy link
Copy Markdown
Member

I don't understand this PR. What was the original issue?

@hannesm
Copy link
Copy Markdown
Member

hannesm commented Oct 29, 2021

The original issue unfolds as follows:

  • domain-name 0.3.1 was released (in [new release] domain-name (0.3.1) #19881) which dropped depeendencies on fmt and astring
  • tezos* failed since it uses "fmt" (missing in opam dependencies, and also in the dune file) -- this was implicitly present by ipaddr depending on domain-name, and tezos-stdlib-unix depending on ipaddr.
  • while CI was running, further missing lower bounds were detected (ezjsonm / fmt)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants