Python 3 one core: Don't check for sys.frozen in the check method. - #9857
Merged
Conversation
feerrenrut
reviewed
Jul 3, 2019
| return True | ||
| # For binary copies, only present this as an available synth if this is Windows 10. | ||
| # Only present this as an available synth if this is Windows 10. | ||
| return winVersion.winVersion.major >= 10 |
Contributor
There was a problem hiding this comment.
There is also winVersion.isWin10. I think this should be converted to use the helper function. The helper has a note that it doesn't work in source copies, but looking at the implementation it looks equivalent to what you have here.
feerrenrut
approved these changes
Jul 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
When running a python 2 copy from source, NVDA is unable to detect if it is running under Windows 10. Therefore, the oneCore synthesizer contains a work around in its check method, always listing the synthesizer in the synthesizer list when running from source, even on Windows versions older than Windows 10.
On Python 3 however, the manifest of the main Python targets Windows 10 and therefore, this workaround is no longer necessary.
Description of how this pull request fixes the issue:
Changed the check method to always evaluate the current windows version.
Testing performed:
Known issues with pull request:
None
Change log entry:
None. This only affects people running from source.