Skip to content

Python 3 one core: Don't check for sys.frozen in the check method. #9857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feerrenrut merged 2 commits into from
Jul 5, 2019
Merged

Python 3 one core: Don't check for sys.frozen in the check method. #9857

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a165d8
Python 3 one core: Don't check for sys.frozen in the check method.
Jul 3, 2019
48c78b0
Review actions
Jul 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions source/synthDrivers/oneCore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,12 +117,7 @@ class SynthDriver(SynthDriver):

@classmethod
def check(cls):
if not hasattr(sys, "frozen"):
# #3793: Source copies don't report the correct version on Windows 10 because Python isn't manifested for higher versions.
# We want this driver to work for source copies on Windows 10, so just return True here.
# If this isn't in fact Windows 10, it will fail when constructed, which is okay.
return True
# For binary copies, only present this as an available synth if this is Windows 10.
# Only present this as an available synth if this is Windows 10.
return winVersion.winVersion.major >= 10

@feerrenrut feerrenrut Jul 3, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also winVersion.isWin10. I think this should be converted to use the helper function. The helper has a note that it doesn't work in source copies, but looking at the implementation it looks equivalent to what you have here.


def _get_supportsProsodyOptions(self):
Expand Down