Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Link): allow partial query match for activeClass #2663

Merged
merged 2 commits into from
Nov 17, 2024

Conversation

sandros94
Copy link
Collaborator

@sandros94 sandros94 commented Nov 16, 2024

πŸ”— Linked issue

Resolves #1905

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This allows to apply activeClasses to Links that have partially matching queries with the current $route.query.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@sandros94 sandros94 marked this pull request as ready for review November 16, 2024 18:51
@sandros94
Copy link
Collaborator Author

sandros94 commented Nov 16, 2024

PR for v3 at #2664

@benjamincanac benjamincanac merged commit 03e24f4 into nuxt:dev Nov 17, 2024
2 checks passed
@benjamincanac
Copy link
Member

Thanks @sandros94! 😊

@sandros94 sandros94 deleted the v2-link-partial-exactQuery branch November 17, 2024 11:16
@sandros94 sandros94 mentioned this pull request Nov 27, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ULink exactQuery, but only match the given ones
2 participants