Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Link): allow partial query match for its active state #2664

Merged
merged 5 commits into from
Nov 17, 2024
Merged

feat(Link): allow partial query match for its active state #2664

merged 5 commits into from
Nov 17, 2024

Conversation

sandros94
Copy link
Collaborator

🔗 Linked issue

Follow-up for #2663

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Implements the same functionality to v3 from the linked PR above

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@sandros94 sandros94 changed the title V3 link partial exact query feat(Link): allow partial query match for its active state Nov 16, 2024
@sandros94 sandros94 self-assigned this Nov 16, 2024
@sandros94 sandros94 added v3 #1289 enhancement New feature or request labels Nov 16, 2024
@sandros94 sandros94 mentioned this pull request Nov 16, 2024
Merged
8 tasks
@sandros94
Copy link
Collaborator Author

The Vue tests also fail on v3

@benjamincanac
Copy link
Member

The Vue tests also fail on v3

My bad! It's fixed

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 16, 2024 

pnpm add https://pkg.pr.new/@nuxt/ui@2664

commit: b253db2

@benjamincanac benjamincanac merged commit 7329900 into nuxt:v3 Nov 17, 2024
2 checks passed
@sandros94 sandros94 deleted the v3-link-partial-exactQuery branch November 17, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees

@sandros94 sandros94

Labels
enhancement New feature or request v3 #1289
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandros94 @benjamincanac