Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Link): exactQuery prop type #2781

Merged
merged 1 commit into from
Nov 27, 2024
Merged

fix(Link): exactQuery prop type #2781

merged 1 commit into from
Nov 27, 2024

Conversation

sandros94
Copy link
Collaborator

🔗 Linked issue

Leftover from #2663
Mentioned in #1905

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Small type I've missed from the prior PR

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@sandros94 sandros94 added the bug Something isn't working label Nov 27, 2024
@sandros94 sandros94 self-assigned this Nov 27, 2024
@benjamincanac benjamincanac merged commit 4cde571 into dev Nov 27, 2024
2 of 3 checks passed
@benjamincanac benjamincanac deleted the fix-v2-link-prop-types branch November 27, 2024 08:47
@benjamincanac
Copy link
Member

@sandros94 You might have missed this implementation in v3 on the Vue Link component as well.

@sandros94
Copy link
Collaborator Author

ui/src/runtime/components/Link.vue

Line 77 in 0f64802

exactQuery?: boolean | 'partial'

In v3 we have prop types exported from the component itself, right?

@benjamincanac Volta.net
Copy link
Member

We have another Link component for Vue: https://github.com/nuxt/ui/blob/v3/src/runtime/vue/components/Link.vue

@sandros94 sandros94 mentioned this pull request Nov 27, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sandros94 sandros94

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandros94 @benjamincanac