fix: modulo overflow in comptime by guipublic · Pull Request #9348 · noir-lang/noir

guipublic · 2025-07-29T10:33:39Z

Description

Problem*

Resolves #9336

Summary*

Handle separately MIN%-1 for signed integers

Additional Context

As per Rust documentation:
The only case where such an overflow can occur is x % y for MIN / -1 on a signed type (where MIN is the negative minimal value), which is invalid due to implementation artifacts.

Documentation*

Check one:

[] No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `24e62a9`	Previous: `8264d30`	Ratio
`test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_reset-kernel-lib`	`2` s	`1` s	`2`
`test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_rollup-lib`	`3` s	`2` s	`1.50`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

aakoshh · 2025-07-29T10:56:27Z

The SSA interpreter also needs updating, see #9336 (comment)

…tepreter)

guipublic · 2025-07-29T16:46:29Z

I updated the SSA interpreter by using signed fields when parsing SSA.

jfecher

Before merging, can you document this behavior in the docs for the % operator?

guipublic · 2025-07-30T08:56:52Z

I updated the doc and asked devrel for a review.

github-actions · 2025-07-30T09:11:17Z

🚀 Deployed on https://688a2083cc46f61aba2f16a5--noir-docs.netlify.app

docs/docs/noir/concepts/ops.md

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `24e62a9`	Previous: `8264d30`	Ratio
`sha512-100-bytes`	`0.145` s	`0.102` s	`1.42`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

github-actions · 2025-07-30T13:39:25Z

FYI @noir-lang/developerrelations on Noir doc changes.

Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix: forbid self-referencing type aliases (noir-lang/noir#9103) chore: add a mem2reg test for when all references need to be invalidated (noir-lang/noir#9377) fix(ssa): Do not check ArrayGet/Set as unreachable for Brillig (noir-lang/noir#9376) chore: use SSA parser in all mem2reg tests (noir-lang/noir#9372) fix: trait where clause check fixes (noir-lang/noir#9369) fix: Correct doc comments for SSA passes (noir-lang/noir#9371) fix: prevent `SignedField::from(i128::MIN)` from crashing (noir-lang/noir#9366) fix: allow constants in the type-system to be negative (noir-lang/noir#9360) feat: show circuit output as a value of the program's return type (noir-lang/noir#9364) feat: add `FunctionDefinition::visibility` (noir-lang/noir#9363) chore(docs): Add example for `$crate` in docs (noir-lang/noir#9361) fix: Prevent accidental tuple sharing in comptime code (noir-lang/noir#9313) fix: perserve purities after SSA normalization (noir-lang/noir#9355) fix: modulo overflow in comptime (noir-lang/noir#9348) fix: handle short-syntax for trait constraints on trait generics (noir-lang/noir#9167) chore: enhance trait constraint comment (noir-lang/noir#9358) fix: replace implicitly added named generics with fresh type vars in check_trait_impl_where_clause_matches_trait_where_clause (noir-lang/noir#9352) fix: push definition trait constraints after trait item constraint (noir-lang/noir#9354) chore(ci): Update status of noir_json_parser (noir-lang/noir#9351) fix(ssa): Keep reference count increments for array set values (noir-lang/noir#9344) chore: remove unused `compile_workspace` (noir-lang/noir#9353) chore: try printing byte arrays as strings in the SSA interpreter (noir-lang/noir#9346) feat(lsp): allow opening noir stdlib files (noir-lang/noir#9339) fix: do u128 operations with u128, not i128 (noir-lang/noir#9345) chore(acir): ACIR parser error handling for blackbox inputs/outputs (noir-lang/noir#9342) fix: prevent invalid types in test/fuzz functions (noir-lang/noir#9343) chore(lsp): avoid redundant type checking (noir-lang/noir#9337) feat(acir): Parse ACIR memory and call opcodes (noir-lang/noir#9331) fix(ssa_gen): Add constraint on slice length before popping (noir-lang/noir#9323) chore: impl for u16 conversions (noir-lang/noir#9314) fix: substitute bindings in type before canonicalization (noir-lang/noir#9328) fix(ssa_interpreter): `push_back` and `pop_back` to slices with padding (noir-lang/noir#9320) fix: wildcard type should be allowed in lambda parameter types (noir-lang/noir#9325) chore: graceful handling of SIGPIPE (noir-lang/noir#9075) feat: return unsolvable opcode from `CircuitSimulator` (noir-lang/noir#8943) fix: allow nested fmtstr (noir-lang/noir#9309) feat: Initial ACIR parser (arithmetic exprs and black box functions) (noir-lang/noir#9316) fix(mem2reg): Register aliases when the `IfElse` result in a reference (noir-lang/noir#9305) fix: Make Ssa-gen use existing reference when compiling `&mut foo.bar.baz` (noir-lang/noir#9307) fix: top-level item in dependency isn't always visible (noir-lang/noir#9295) fix(ssa-interpreter): Return error if slice length is 0 during popping (noir-lang/noir#9308) chore: Release Noir(1.0.0-beta.9) (noir-lang/noir#9184) chore(LSP): simplify code lens request handling (noir-lang/noir#9279) chore: add regression tests for #6383 (noir-lang/noir#9302) fix: disallow `_` in signatures and struct members (noir-lang/noir#9301) fix: check associated types after validating where clause when looking up trait impls, plus some unification fixes (noir-lang/noir#9265) chore: Add fmtstr to coercions list (noir-lang/noir#9300) chore: Add a helper function `fmtstr::as_quoted_str` (noir-lang/noir#9293) chore(docs): Copy Type Coercions docs into v1.0.0-beta.8 versioned docs (noir-lang/noir#9298) feat: only inject "out of bounds" checks in brillig (noir-lang/noir#9200) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Maxim Vezenov <mvezenov@gmail.com>

fix modulo overflow in comptime

034ff0e

github-actions bot reviewed Jul 29, 2025

View reviewed changes

guipublic and others added 2 commits July 29, 2025 18:45

use signed fields when parsing ssa (and then fix modulo -1 for ssa in…

7e701c4

…tepreter)

Merge branch 'master' into gd/issue_9336

ee14b49

guipublic requested a review from a team July 29, 2025 17:00

jfecher approved these changes Jul 29, 2025

View reviewed changes

add modulo operator in the documentation

7d96c47

guipublic requested a review from a team July 30, 2025 08:56

github-actions bot added the documentation Improvements or additions to documentation label Jul 30, 2025

jfecher reviewed Jul 30, 2025

View reviewed changes

docs/docs/noir/concepts/ops.md Show resolved Hide resolved

docs/docs/noir/concepts/ops.md Show resolved Hide resolved

Merge branch 'master' into gd/issue_9336

24e62a9

github-actions bot reviewed Jul 30, 2025

View reviewed changes

guipublic added this pull request to the merge queue Jul 30, 2025

Merged via the queue into master with commit 922efbd Jul 30, 2025
101 checks passed

guipublic deleted the gd/issue_9336 branch July 30, 2025 15:08

noirwhal mentioned this pull request Jul 30, 2025

chore: Release Noir(1.0.0-beta.10) #9311

Merged

AztecBot mentioned this pull request Jul 31, 2025

chore: Bump Noir reference AztecProtocol/aztec-packages#16127

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: modulo overflow in comptime#9348

fix: modulo overflow in comptime#9348
guipublic merged 5 commits intomasterfrom
gd/issue_9336

guipublic commented Jul 29, 2025 •

edited

Loading

Uh oh!

github-actions bot left a comment •

edited

Loading

Uh oh!

aakoshh commented Jul 29, 2025

Uh oh!

guipublic commented Jul 29, 2025

Uh oh!

jfecher left a comment

Uh oh!

guipublic commented Jul 30, 2025

Uh oh!

github-actions bot commented Jul 30, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot commented Jul 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

guipublic commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Problem*

Summary*

Additional Context

Documentation*

PR Checklist*

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

aakoshh commented Jul 29, 2025

Uh oh!

guipublic commented Jul 29, 2025

Uh oh!

jfecher left a comment

Choose a reason for hiding this comment

Uh oh!

guipublic commented Jul 30, 2025

Uh oh!

github-actions bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

github-actions bot commented Jul 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

guipublic commented Jul 29, 2025 •

edited

Loading

github-actions bot left a comment •

edited

Loading

github-actions bot commented Jul 30, 2025 •

edited

Loading