chore: impl for u16 conversions by jialinli98 · Pull Request #9314 · noir-lang/noir

jialinli98 · 2025-07-24T16:01:15Z

Description

Problem*

Resolves

Summary*

Additional Context

Documentation*

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `15e447e`	Previous: `37e8b2d`	Ratio
`test_report_zkpassport_noir-ecdsa_`	`2` s	`1` s	`2`
`test_report_zkpassport_noir_rsa_`	`2` s	`1` s	`2`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

noir_stdlib/src/convert.nr

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `fd21857`	Previous: `edd42f8`	Ratio
`sha512-100-bytes`	`0.132` s	`0.105` s	`1.26`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

TomAFrench · 2025-07-25T12:35:00Z

Huh, @asterite do you know why we're getting an error in nargo expand?

asterite · 2025-07-25T13:51:03Z

Huh, @asterite do you know why we're getting an error in nargo expand?

That's very strange! I'm checking the expanded code and when you do nargo check or nargo expand it will give a compile error, but if you do nargo compile or nargo execute it works fine 🤔 I'll take a look...

asterite · 2025-07-25T14:05:20Z

For this PR we could ignore that test, if it's blocking.

asterite · 2025-07-25T14:14:57Z

Captured an issue in #9326

Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix: forbid self-referencing type aliases (noir-lang/noir#9103) chore: add a mem2reg test for when all references need to be invalidated (noir-lang/noir#9377) fix(ssa): Do not check ArrayGet/Set as unreachable for Brillig (noir-lang/noir#9376) chore: use SSA parser in all mem2reg tests (noir-lang/noir#9372) fix: trait where clause check fixes (noir-lang/noir#9369) fix: Correct doc comments for SSA passes (noir-lang/noir#9371) fix: prevent `SignedField::from(i128::MIN)` from crashing (noir-lang/noir#9366) fix: allow constants in the type-system to be negative (noir-lang/noir#9360) feat: show circuit output as a value of the program's return type (noir-lang/noir#9364) feat: add `FunctionDefinition::visibility` (noir-lang/noir#9363) chore(docs): Add example for `$crate` in docs (noir-lang/noir#9361) fix: Prevent accidental tuple sharing in comptime code (noir-lang/noir#9313) fix: perserve purities after SSA normalization (noir-lang/noir#9355) fix: modulo overflow in comptime (noir-lang/noir#9348) fix: handle short-syntax for trait constraints on trait generics (noir-lang/noir#9167) chore: enhance trait constraint comment (noir-lang/noir#9358) fix: replace implicitly added named generics with fresh type vars in check_trait_impl_where_clause_matches_trait_where_clause (noir-lang/noir#9352) fix: push definition trait constraints after trait item constraint (noir-lang/noir#9354) chore(ci): Update status of noir_json_parser (noir-lang/noir#9351) fix(ssa): Keep reference count increments for array set values (noir-lang/noir#9344) chore: remove unused `compile_workspace` (noir-lang/noir#9353) chore: try printing byte arrays as strings in the SSA interpreter (noir-lang/noir#9346) feat(lsp): allow opening noir stdlib files (noir-lang/noir#9339) fix: do u128 operations with u128, not i128 (noir-lang/noir#9345) chore(acir): ACIR parser error handling for blackbox inputs/outputs (noir-lang/noir#9342) fix: prevent invalid types in test/fuzz functions (noir-lang/noir#9343) chore(lsp): avoid redundant type checking (noir-lang/noir#9337) feat(acir): Parse ACIR memory and call opcodes (noir-lang/noir#9331) fix(ssa_gen): Add constraint on slice length before popping (noir-lang/noir#9323) chore: impl for u16 conversions (noir-lang/noir#9314) fix: substitute bindings in type before canonicalization (noir-lang/noir#9328) fix(ssa_interpreter): `push_back` and `pop_back` to slices with padding (noir-lang/noir#9320) fix: wildcard type should be allowed in lambda parameter types (noir-lang/noir#9325) chore: graceful handling of SIGPIPE (noir-lang/noir#9075) feat: return unsolvable opcode from `CircuitSimulator` (noir-lang/noir#8943) fix: allow nested fmtstr (noir-lang/noir#9309) feat: Initial ACIR parser (arithmetic exprs and black box functions) (noir-lang/noir#9316) fix(mem2reg): Register aliases when the `IfElse` result in a reference (noir-lang/noir#9305) fix: Make Ssa-gen use existing reference when compiling `&mut foo.bar.baz` (noir-lang/noir#9307) fix: top-level item in dependency isn't always visible (noir-lang/noir#9295) fix(ssa-interpreter): Return error if slice length is 0 during popping (noir-lang/noir#9308) chore: Release Noir(1.0.0-beta.9) (noir-lang/noir#9184) chore(LSP): simplify code lens request handling (noir-lang/noir#9279) chore: add regression tests for #6383 (noir-lang/noir#9302) fix: disallow `_` in signatures and struct members (noir-lang/noir#9301) fix: check associated types after validating where clause when looking up trait impls, plus some unification fixes (noir-lang/noir#9265) chore: Add fmtstr to coercions list (noir-lang/noir#9300) chore: Add a helper function `fmtstr::as_quoted_str` (noir-lang/noir#9293) chore(docs): Copy Type Coercions docs into v1.0.0-beta.8 versioned docs (noir-lang/noir#9298) feat: only inject "out of bounds" checks in brillig (noir-lang/noir#9200) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Maxim Vezenov <mvezenov@gmail.com>

impl for u16

971d81f

github-actions bot reviewed Jul 24, 2025

View reviewed changes

TomAFrench reviewed Jul 24, 2025

View reviewed changes

noir_stdlib/src/convert.nr Outdated Show resolved Hide resolved

Update noir_stdlib/src/convert.nr

fd21857

github-actions bot reviewed Jul 24, 2025

View reviewed changes

TomAFrench added 4 commits July 24, 2025 17:04

chore: fmt

137c03a

.

293f6ad

Merge branch 'master' into jl/u16_impl

1d4a5f3

Merge branch 'master' into jl/u16_impl

baf93bb

.

4aa0ae8

TomAFrench enabled auto-merge July 25, 2025 14:50

TomAFrench approved these changes Jul 25, 2025

View reviewed changes

TomAFrench added this pull request to the merge queue Jul 25, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 25, 2025

TomAFrench added this pull request to the merge queue Jul 25, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 25, 2025

Merge branch 'master' into jl/u16_impl

4df20c4

TomAFrench added this pull request to the merge queue Jul 25, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 25, 2025

asterite added 2 commits July 25, 2025 16:16

Merge branch 'master' into jl/u16_impl

445ba3b

Merge branch 'jl/u16_impl' of github.com:noir-lang/noir into jl/u16_impl

d78f3de

asterite enabled auto-merge July 25, 2025 19:17

asterite added this pull request to the merge queue Jul 25, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 25, 2025

.

15e447e

TomAFrench enabled auto-merge July 25, 2025 20:14

TomAFrench added this pull request to the merge queue Jul 25, 2025

Merged via the queue into master with commit e7fb7f3 Jul 25, 2025
101 checks passed

TomAFrench deleted the jl/u16_impl branch July 25, 2025 20:57

This was referenced Jul 26, 2025

chore: Bump Noir reference AztecProtocol/aztec-packages#15899

Merged

chore: Bump Noir reference AztecProtocol/aztec-packages#16127

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: impl for u16 conversions#9314

chore: impl for u16 conversions#9314
TomAFrench merged 11 commits intomasterfrom
jl/u16_impl

jialinli98 commented Jul 24, 2025

Uh oh!

github-actions bot left a comment •

edited

Loading

Uh oh!

Uh oh!

github-actions bot left a comment

Uh oh!

TomAFrench commented Jul 25, 2025

Uh oh!

asterite commented Jul 25, 2025 •

edited

Loading

Uh oh!

asterite commented Jul 25, 2025

Uh oh!

asterite commented Jul 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jialinli98 commented Jul 24, 2025

Description

Problem*

Summary*

Additional Context

Documentation*

PR Checklist*

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

TomAFrench commented Jul 25, 2025

Uh oh!

asterite commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

asterite commented Jul 25, 2025

Uh oh!

asterite commented Jul 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot left a comment •

edited

Loading

asterite commented Jul 25, 2025 •

edited

Loading