fix(ssa): Signed cast simplification by vezenovm · Pull Request #8862 · noir-lang/noir

vezenovm · 2025-06-10T15:14:15Z

Description

Problem*

Resolves #8833
Resolves #8305

Alternative to #8843, reference #8843 (comment) and preceding comments for more information.

Summary*

Use our IntegerConstant structure for converting field constants to the expected signed integers.

Additional Context

Documentation*

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `0b9c3f3`	Previous: `fa9f737`	Ratio
`rollup-merge`	`0.004` s	`0.003` s	`1.33`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `ddb347b`	Previous: `98d19fb`	Ratio
`test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_types`	`92` s	`73` s	`1.26`
`test_report_zkpassport_noir-ecdsa_`	`128` s	`93` s	`1.38`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

github-actions · 2025-06-10T15:48:39Z

Changes to number of Brillig opcodes executed

Generated at commit: a37636f7e20cbb95c9012ba622ad810d1ac8414e, compared to commit: 98d19fb4d61fd3b4f6420862af2d5f7af8a30f0f

🧾 Summary (10% most significant diffs)

Program	Brillig opcodes (+/-)	%
signed_comparison_inliner_max	-7 ✅	-6.54%
signed_comparison_inliner_min	-7 ✅	-6.54%
signed_comparison_inliner_zero	-7 ✅	-6.54%

Full diff report 👇

Program	Brillig opcodes (+/-)	%
unary_operator_overloading_inliner_min	55 (-1)	-1.79%
unary_operator_overloading_inliner_max	40 (-1)	-2.44%
unary_operator_overloading_inliner_zero	40 (-1)	-2.44%
signed_arithmetic_inliner_max	198 (-5)	-2.46%
signed_arithmetic_inliner_min	198 (-5)	-2.46%
signed_arithmetic_inliner_zero	198 (-5)	-2.46%
signed_comparison_inliner_max	100 (-7)	-6.54%
signed_comparison_inliner_min	100 (-7)	-6.54%
signed_comparison_inliner_zero	100 (-7)	-6.54%

github-actions · 2025-06-10T15:48:44Z

Changes to Brillig bytecode sizes

Generated at commit: a37636f7e20cbb95c9012ba622ad810d1ac8414e, compared to commit: 98d19fb4d61fd3b4f6420862af2d5f7af8a30f0f

🧾 Summary (10% most significant diffs)

Program	Brillig opcodes (+/-)	%
signed_comparison_inliner_max	-9 ✅	-6.92%
signed_comparison_inliner_min	-9 ✅	-6.92%
signed_comparison_inliner_zero	-9 ✅	-6.92%

Full diff report 👇

Program	Brillig opcodes (+/-)	%
unary_operator_overloading_inliner_min	61 (-1)	-1.61%
unary_operator_overloading_inliner_max	50 (-1)	-1.96%
unary_operator_overloading_inliner_zero	50 (-1)	-1.96%
signed_arithmetic_inliner_max	241 (-7)	-2.82%
signed_arithmetic_inliner_min	241 (-7)	-2.82%
signed_arithmetic_inliner_zero	241 (-7)	-2.82%
signed_comparison_inliner_max	121 (-9)	-6.92%
signed_comparison_inliner_min	121 (-9)	-6.92%
signed_comparison_inliner_zero	121 (-9)	-6.92%

asterite

Looks good!

…n' into mv/fix-signed-cast-simplification

Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix(LSP): suggest generic type methods (noir-lang/noir#8948) fix: Fix if/match tracking in last uses pass (noir-lang/noir#8935) fix(ssa): Swap Brillig index shift and DIE in minimal pipeline (noir-lang/noir#8946) fix: when macro parse error happens, discard warnings; also preserve unquoted token locations (noir-lang/noir#8944) chore: disable noncritical workflow steps which fail on external prs (noir-lang/noir#8939) chore(test): Add `--minimal-ssa` to integration tests (noir-lang/noir#8938) fix(noirc_evaluator): U128 Binary::And simplification (noir-lang/noir#8940) chore: Improve access to data required to extract Noir (noir-lang/noir#8793) chore: bump external pinned commits (noir-lang/noir#8920) chore(fuzz): Compare print output on failed programs (noir-lang/noir#8921) chore(fuzz): Display nightly fuzz status badge (noir-lang/noir#8932) fix(fuzz): Consider values returned from Brillig to ACIR as dynamic (noir-lang/noir#8931) fix(fuzz): Fix env var name in fuzzing workflow (noir-lang/noir#8929) chore(fuzz): Add nightly fuzz workflow with 5 minute budget (noir-lang/noir#8925) fix(mem2reg): Keep last store for a used nested array (noir-lang/noir#8917) chore(fuzz): Increase the number of deterministic test cases (noir-lang/noir#8872) fix: Create calls to `apply` before function values are changed to fields in defunctionalize (noir-lang/noir#8916) chore: Add various regression tests for mutable references (noir-lang/noir#8915) fix: handle return_data in the interpreter SSA CLI (noir-lang/noir#8914) feat(fuzz): Generate references in the AST fuzzer (noir-lang/noir#8728) fix(fuzz): Use an inline block to circumvent negation with overflow (noir-lang/noir#8911) fix: Inline global arrays with functions at their call site (noir-lang/noir#8905) chore: Casting ACIR vs Brillig regression tests (noir-lang/noir#8903) fix(mem2reg): Keep last store for reference in array used only in an array get (noir-lang/noir#8877) fix: more SSA interpreter fixes (noir-lang/noir#8904) chore: Ban dynamic array indices with reference elements (noir-lang/noir#8888) chore(ssa_fuzzer): Add SSA validation to the SSA fuzzer (noir-lang/noir#8901) chore(fuzz): More metamorphic rules (noir-lang/noir#8857) fix: catch unbound type variables during frontend compilation (noir-lang/noir#8686) fix: preserve functions which are used in `array_set` instructions (noir-lang/noir#8891) fix: assorted SSA interpreter fixes (noir-lang/noir#8893) fix(ssa): Signed cast simplification (noir-lang/noir#8862) feat: simplify apply function cfg immediately (noir-lang/noir#8895) fix: do not hoist control dependent cast (noir-lang/noir#8886) fix(licm): Account for negative bounds when checking whether a loop executes (noir-lang/noir#8889) chore: Release Noir(1.0.0-beta.7) (noir-lang/noir#8520) chore: test noir-ecdsa library in CI (noir-lang/noir#8859) chore: Incorrect clippy warning blocking PRs (noir-lang/noir#8861) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>

vezenovm added 2 commits June 10, 2025 15:12

fix signed cast simplification

c180335

snaps

bc52538

github-actions bot reviewed Jun 10, 2025

View reviewed changes

do not simplify OOB value

a7fa749

github-actions bot reviewed Jun 10, 2025

View reviewed changes

gate against casts to i128

dfe07e4

vezenovm mentioned this pull request Jun 10, 2025

fix: don't check for overflow when binary operation is simplified to constant #8843

Closed

5 tasks

Merge branch 'master' into mv/fix-signed-cast-simplification

d1b78f2

vezenovm requested a review from a team June 10, 2025 16:00

asterite approved these changes Jun 10, 2025

View reviewed changes

vezenovm added 3 commits June 10, 2025 16:12

cleanup comment and snaps

32c1f9b

Merge remote-tracking branch 'origin/mv/fix-signed-cast-simplificatio…

8fc80ae

…n' into mv/fix-signed-cast-simplification

more snaps

486744c

vezenovm enabled auto-merge June 10, 2025 16:15

bump timeout

265dcba

vezenovm mentioned this pull request Jun 10, 2025

fix(interpreter): Promote ConstantDoesNotFitInType to non-internal error #8866

Closed

5 tasks

vezenovm added 6 commits June 10, 2025 16:32

Merge branch 'master' into mv/fix-signed-cast-simplification

0b9c3f3

Merge branch 'master' into mv/fix-signed-cast-simplification

b8ab70b

return value in prover toml and snap

10456e8

Merge branch 'master' into mv/fix-signed-cast-simplification

f89bef8

bump noir_bigcurve timeout

b7bff3b

snaps

2d3f73e

vezenovm added this pull request to the merge queue Jun 12, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 12, 2025

vezenovm added this pull request to the merge queue Jun 12, 2025

Merge branch 'master' into mv/fix-signed-cast-simplification

7251df0

vezenovm removed this pull request from the merge queue due to a manual request Jun 12, 2025

snaps after master merge

ddb347b

vezenovm enabled auto-merge June 12, 2025 14:24

bump crates/types timeout

72311f6

vezenovm added this pull request to the merge queue Jun 12, 2025

Merged via the queue into master with commit bcfb293 Jun 12, 2025
118 checks passed

vezenovm deleted the mv/fix-signed-cast-simplification branch June 12, 2025 15:26

noirwhal mentioned this pull request Jun 12, 2025

chore: Release Noir(1.0.0-beta.8) #8892

Merged

AztecBot mentioned this pull request Jun 13, 2025

chore: Bump Noir reference AztecProtocol/aztec-packages#15024

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ssa): Signed cast simplification#8862

fix(ssa): Signed cast simplification#8862
vezenovm merged 18 commits intomasterfrom
mv/fix-signed-cast-simplification

vezenovm commented Jun 10, 2025 •

edited

Loading

Uh oh!

github-actions bot left a comment •

edited

Loading

Uh oh!

github-actions bot left a comment •

edited

Loading

Uh oh!

github-actions bot commented Jun 10, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 10, 2025 •

edited

Loading

Uh oh!

asterite left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

vezenovm commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Problem*

Summary*

Additional Context

Documentation*

PR Checklist*

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

github-actions bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes to number of Brillig opcodes executed

🧾 Summary (10% most significant diffs)

Uh oh!

github-actions bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes to Brillig bytecode sizes

🧾 Summary (10% most significant diffs)

Uh oh!

asterite left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vezenovm commented Jun 10, 2025 •

edited

Loading

github-actions bot left a comment •

edited

Loading

github-actions bot left a comment •

edited

Loading

github-actions bot commented Jun 10, 2025 •

edited

Loading

github-actions bot commented Jun 10, 2025 •

edited

Loading