feat(fuzz): Generate references in the AST fuzzer by aakoshh · Pull Request #8728 · noir-lang/noir

aakoshh · 2025-05-30T11:28:39Z

Description

Problem*

Resolves #7939

Summary*

Generates parameter and return types with &mut.

TODO:

Need to change generation to avoid dynamic indexes to access arrays with references after chore: Ban dynamic array indices with reference elements #8888

Additional Context

Some bugs I discovered during testing this were:

Execution crash: value is not typed as brillig usize #8727
Compiler crash: condition value is not a boolean #8723
Compiler crash: returning &mut from if #8722
Compiler crash: load instruction has attempted to access previously unused memory location #8729
Compiler crash: condition value is not a boolean: MismatchedBitSize (without if-then) #8739
Compiler crash: Cannot return references from an if expression (re-assigning mut &mut) #8741
Compiler crash: Cannot return references from an if expression (array of &mut) #8748
Compiler crash: Expected RuntimeError to have a location. Could not resolve some references to the array. #8750
Compiler crash: Could not resolve some references to the array (without any dynamic index) #8761
Brillig != minimal: divide by zero; SSA interpeter: InternalError after step mem2reg #8755
Compiler crash: break in assignment #8770
Execution crash: condition value is not a boolean: MismatchedBitSize #8786
Execution crash: condition value is not a boolean: MismatchedBitSize (reassign mut &mut, no if-then) #8803
ACIR crash; Brillig incorrect; SSA internal error: mem2reg with nested arrays and references #8909

Documentation*

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `edff4e9`	Previous: `753ad6f`	Ratio
`rollup-merge`	`0.004` s	`0.003` s	`1.33`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `5b88102`	Previous: `753ad6f`	Ratio
`private-kernel-inner`	`3.132` s	`2.256` s	`1.39`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `5b88102`	Previous: `202130c`	Ratio
`test_report_zkpassport_noir_rsa_`	`2` s	`1` s	`2`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

… af/7939-ast-fuzz-ref

Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix(LSP): suggest generic type methods (noir-lang/noir#8948) fix: Fix if/match tracking in last uses pass (noir-lang/noir#8935) fix(ssa): Swap Brillig index shift and DIE in minimal pipeline (noir-lang/noir#8946) fix: when macro parse error happens, discard warnings; also preserve unquoted token locations (noir-lang/noir#8944) chore: disable noncritical workflow steps which fail on external prs (noir-lang/noir#8939) chore(test): Add `--minimal-ssa` to integration tests (noir-lang/noir#8938) fix(noirc_evaluator): U128 Binary::And simplification (noir-lang/noir#8940) chore: Improve access to data required to extract Noir (noir-lang/noir#8793) chore: bump external pinned commits (noir-lang/noir#8920) chore(fuzz): Compare print output on failed programs (noir-lang/noir#8921) chore(fuzz): Display nightly fuzz status badge (noir-lang/noir#8932) fix(fuzz): Consider values returned from Brillig to ACIR as dynamic (noir-lang/noir#8931) fix(fuzz): Fix env var name in fuzzing workflow (noir-lang/noir#8929) chore(fuzz): Add nightly fuzz workflow with 5 minute budget (noir-lang/noir#8925) fix(mem2reg): Keep last store for a used nested array (noir-lang/noir#8917) chore(fuzz): Increase the number of deterministic test cases (noir-lang/noir#8872) fix: Create calls to `apply` before function values are changed to fields in defunctionalize (noir-lang/noir#8916) chore: Add various regression tests for mutable references (noir-lang/noir#8915) fix: handle return_data in the interpreter SSA CLI (noir-lang/noir#8914) feat(fuzz): Generate references in the AST fuzzer (noir-lang/noir#8728) fix(fuzz): Use an inline block to circumvent negation with overflow (noir-lang/noir#8911) fix: Inline global arrays with functions at their call site (noir-lang/noir#8905) chore: Casting ACIR vs Brillig regression tests (noir-lang/noir#8903) fix(mem2reg): Keep last store for reference in array used only in an array get (noir-lang/noir#8877) fix: more SSA interpreter fixes (noir-lang/noir#8904) chore: Ban dynamic array indices with reference elements (noir-lang/noir#8888) chore(ssa_fuzzer): Add SSA validation to the SSA fuzzer (noir-lang/noir#8901) chore(fuzz): More metamorphic rules (noir-lang/noir#8857) fix: catch unbound type variables during frontend compilation (noir-lang/noir#8686) fix: preserve functions which are used in `array_set` instructions (noir-lang/noir#8891) fix: assorted SSA interpreter fixes (noir-lang/noir#8893) fix(ssa): Signed cast simplification (noir-lang/noir#8862) feat: simplify apply function cfg immediately (noir-lang/noir#8895) fix: do not hoist control dependent cast (noir-lang/noir#8886) fix(licm): Account for negative bounds when checking whether a loop executes (noir-lang/noir#8889) chore: Release Noir(1.0.0-beta.7) (noir-lang/noir#8520) chore: test noir-ecdsa library in CI (noir-lang/noir#8859) chore: Incorrect clippy warning blocking PRs (noir-lang/noir#8861) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>

aakoshh added 5 commits May 29, 2025 20:20

The reference oprator returns a reference type

8e346dc

Generate reference type expressions

86140c5

Do not try to return ref from if-then-else

4bbcaa4

A function returning a reference won't call others for now

7e6d7cd

Pass global functions by indirect reference

84ed3b9

github-actions bot reviewed May 30, 2025

View reviewed changes

Fix clippy

47962d1

aakoshh mentioned this pull request May 30, 2025

Compiler crash: load instruction has attempted to access previously unused memory location #8729

Closed

aakoshh added 3 commits May 30, 2025 20:54

Merge remote-tracking branch 'origin/master' into af/7939-ast-fuzz-ref

87cb094

Do not treat functions passed by deref

8c78bd7

Merge remote-tracking branch 'origin/master' into af/7939-ast-fuzz-ref

6bf936b

aakoshh mentioned this pull request May 30, 2025

Compiler crash: Cannot return references from an if expression (re-assigning mut &mut) #8741

Closed

We can have mutable and non-mutable &mut parameters

485a034

aakoshh mentioned this pull request Jun 2, 2025

Compiler crash: Cannot return references from an if expression (array of &mut) #8748

Closed

Avoid assigning to references in if-then-else

8d9e69f

aakoshh mentioned this pull request Jun 2, 2025

Compiler crash: Expected RuntimeError to have a location. Could not resolve some references to the array. #8750

Closed

aakoshh added 2 commits June 2, 2025 14:45

Fix comptime generation to avoid refs in ABI

ea5aaa4

Fix panic when there are no local mutable variables

393d8c4

aakoshh added 2 commits June 2, 2025 20:25

Fix the SSA interpreter usage to recreate the args from scratch

d3c1fb1

Don't take reference over array item

49d8f82

github-actions bot reviewed Jun 2, 2025

View reviewed changes

aakoshh mentioned this pull request Jun 3, 2025

Compiler crash: break in assignment #8770

Closed

aakoshh added 4 commits June 3, 2025 13:38

Do not count oracle calls as recursive

1655213

Merge remote-tracking branch 'origin/master' into af/7939-ast-fuzz-ref

16e22ee

Consider calling function pointers through mutable references

d2d46f6

Change the lambdas and calls sites to unconstrained

0ce143d

Just the ticket number

87dc461

aakoshh mentioned this pull request Jun 6, 2025

feat(fuzz): Generate arbitrary constraints #8820

Merged

5 tasks

Merge branch 'master' into af/7939-ast-fuzz-ref

cd08675

rkarabut self-requested a review June 8, 2025 17:33

rkarabut approved these changes Jun 8, 2025

View reviewed changes

aakoshh added 7 commits June 9, 2025 09:25

Merge remote-tracking branch 'origin/master' into af/7939-ast-fuzz-ref

8f838fd

Merge branch 'af/7939-ast-fuzz-ref' of github.com:noir-lang/noir into…

03a1cd3

… af/7939-ast-fuzz-ref

Merge remote-tracking branch 'origin/master' into af/7939-ast-fuzz-ref

eebef28

Merge branch 'master' into af/7939-ast-fuzz-ref

0525980

Do not reassign variables with mutable references

837e642

Merge remote-tracking branch 'origin/master' into af/7939-ast-fuzz-ref

9554f1c

Merge remote-tracking branch 'origin/master' into af/7939-ast-fuzz-ref

ac2b123

This was referenced Jun 13, 2025

SSA Interpreter: Recovers from UninitializedReferenceValueLoaded #8908

Closed

ACIR != Brillig: both fail but differently #8910

Closed

aakoshh added 3 commits June 13, 2025 12:00

Don't morph anything with a reference into an if

917c096

Use an inline block to circumvent negation with overflow

b1da524

Merge remote-tracking branch 'origin/master' into af/7939-ast-fuzz-ref

d6d9379

aakoshh mentioned this pull request Jun 13, 2025

chore(fuzz): Track dynamic inputs for array indexing #8912

Merged

5 tasks

aakoshh added 4 commits June 13, 2025 15:51

Merge branch 'master' into af/7939-ast-fuzz-ref

7f1b298

chore(fuzz): Track dynamic inputs for array indexing (#8912)

c55f23c

Merge branch 'master' into af/7939-ast-fuzz-ref

5b88102

Fix clippy

edff4e9

aakoshh added this pull request to the merge queue Jun 13, 2025

Merged via the queue into master with commit 071c897 Jun 13, 2025
118 checks passed

aakoshh deleted the af/7939-ast-fuzz-ref branch June 13, 2025 16:34

noirwhal mentioned this pull request Jun 13, 2025

chore: Release Noir(1.0.0-beta.8) #8892

Merged

AztecBot mentioned this pull request Jun 14, 2025

chore: Bump Noir reference AztecProtocol/aztec-packages#15024

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(fuzz): Generate references in the AST fuzzer#8728

feat(fuzz): Generate references in the AST fuzzer#8728
aakoshh merged 45 commits intomasterfrom
af/7939-ast-fuzz-ref

aakoshh commented May 30, 2025 •

edited

Loading

Uh oh!

github-actions bot left a comment •

edited

Loading

Uh oh!

github-actions bot left a comment •

edited

Loading

Uh oh!

github-actions bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

aakoshh commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Problem*

Summary*

Additional Context

Documentation*

PR Checklist*

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

aakoshh commented May 30, 2025 •

edited

Loading

github-actions bot left a comment •

edited

Loading

github-actions bot left a comment •

edited

Loading

github-actions bot left a comment •

edited

Loading