feat: avoid branch condition negations in ValueMerger#6073
Closed
TomAFrench wants to merge 11 commits intomasterfrom
Closed
feat: avoid branch condition negations in ValueMerger#6073TomAFrench wants to merge 11 commits intomasterfrom
ValueMerger#6073TomAFrench wants to merge 11 commits intomasterfrom
Conversation
Contributor
Changes to circuit sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Member
Author
|
@guipublic This could be something interesting to take up. I'm not able to devote proper time to it atm but it looks very promising in terms of gate count reductions. I'm not sure why the |
This was referenced Oct 29, 2024
This was referenced Nov 1, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This PR modifies how we merge values from
pred * a + (1-pred) * btob + pred * (a-b)which avoids another multiplication. This is being done manually in here so it's worth considering as the default merger strategy.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.