Merged
Conversation
jfecher
requested changes
Nov 16, 2022
jfecher
reviewed
Nov 16, 2022
jfecher
approved these changes
Nov 17, 2022
Contributor
There was a problem hiding this comment.
The error message id decent enough now that users can reasonably figure out what went wrong and fix it if they encounter this.
It doesn't mention unit types if they were used, but these are perhaps less likely to be accidentally used in a comparison than struct/tuple types.
TomAFrench
added a commit
to TomAFrench/noir
that referenced
this pull request
Nov 19, 2022
* master: Array sort (noir-lang#477) Add `--allow-warnings` flag to treat certain errors as warnings (noir-lang#481) Improve field comparison error message (noir-lang#499) Disable debug output during integration tests (noir-lang#494) Aligns build to (noir-lang#443) Refactor stdlib into a separate noir library (noir-lang#496)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
Add array::sort() in noir standard library.
Test additions / changes
This PR requires #475 for the sort to work properly.