Merged
Conversation
Contributor
Author
|
Before: After: |
guipublic
approved these changes
Nov 17, 2022
Contributor
guipublic
left a comment
There was a problem hiding this comment.
I think we should enable field comparison, but until then it is better to report the error. We can easily enable it in the type checker when we will do field comparison.
TomAFrench
added a commit
to TomAFrench/noir
that referenced
this pull request
Nov 19, 2022
* master: Array sort (noir-lang#477) Add `--allow-warnings` flag to treat certain errors as warnings (noir-lang#481) Improve field comparison error message (noir-lang#499) Disable debug output during integration tests (noir-lang#494) Aligns build to (noir-lang#443) Refactor stdlib into a separate noir library (noir-lang#496)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Related to #498
Description
The type system used to allow field comparisons, but since these operations are invalid we would eventually fail in SSA with a compiler crash. This fixes the check in the type system to disallow comparison for fields, but allow eq and neq operations.
Checklist
cargo fmtwith default settings.