Fix conditional with array parameter#475
Merged
Conversation
Merged
vezenovm
approved these changes
Nov 15, 2022
Contributor
vezenovm
left a comment
vezenovm
left a comment
There was a problem hiding this comment.
LGTM. I also like the change for passing an entry block into the TreeBuilder thus removing the need for the dummy block ID.
jfecher
approved these changes
Nov 16, 2022
TomAFrench
added a commit
to TomAFrench/noir
that referenced
this pull request
Nov 16, 2022
* master: Fix conditional with array parameter (noir-lang#475) Constant evaluation of to_bits() (noir-lang#464) propagate error from cse (noir-lang#478) use return value only when witness are all solved (noir-lang#473)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Array function parameters where not properly conditioned inside an IF branch because the instructions creating the arrays are added during inlining, after the function is compiled.
Summary of changes
When the function is compiled, we indicate that array parameters are created inside the function entry block.