feat(traits): Implement trait bounds def collector + resolver passes#2716
Merged
jfecher merged 7 commits intonoir-lang:masterfrom Sep 20, 2023
Merged
feat(traits): Implement trait bounds def collector + resolver passes#2716jfecher merged 7 commits intonoir-lang:masterfrom
jfecher merged 7 commits intonoir-lang:masterfrom
Conversation
5 tasks
5147546 to
d59c5db
Compare
8 tasks
59f8922 to
c9f758c
Compare
c9f758c to
b8112da
Compare
jfecher
reviewed
Sep 20, 2023
jfecher
approved these changes
Sep 20, 2023
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs to be merged after #2652 - this PR also unfortunately includes the changes from that and the diff is currently quite ugly
Problem*
Summary*
Progress on #2568
This is the first part of a two-episode series on Trait Bounds. It turned out quite big, so I've split it into two - the next PR adds the type checker & monomorphizer for where clauses which is the majority of the work, this is some setup work that needs to get done in the early passes.
Changes:
find_trait_or_emit_errorwhich is helpful when walking over the where clauseTraitIdsto the UnresolvedTraitConstraintsDocumentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.