This repository was archived by the owner on Apr 9, 2024. It is now read-only.
feat: Derive Copy for Language#406
Merged
TomAFrench merged 1 commit intomasterfrom Jul 3, 2023
Merged
Conversation
5 tasks
Contributor
Author
|
I just used |
phated
force-pushed
the
phated/copy-language
branch
from
737aaf9 to
b70397f
Compare
TomAFrench
approved these changes
Jul 3, 2023
TomAFrench
changed the title
Copy for Language
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This adds
Copyto the languages. There's no reason we should need to pass references forLanguagebecause it can derive copy.Additional Context
This PR is applied to the 0.15.1 release so I can us it against noir but it should apply cleanly.
PR Checklist*
cargo fmton default settings.BEGIN_COMMIT_OVERRIDE
feat(acvm): Derive
CopyforLanguage(#406)END_COMMIT_OVERRIDE