chore(ssa refactor): Update mem2reg pass to work with multiple functions and blocks#1375
Merged
joss-aztec merged 4 commits intomasterfrom May 22, 2023
Merged
chore(ssa refactor): Update mem2reg pass to work with multiple functions and blocks#1375joss-aztec merged 4 commits intomasterfrom
joss-aztec merged 4 commits intomasterfrom
Conversation
joss-aztec
suggested changes
May 22, 2023
Contributor
joss-aztec
left a comment
joss-aztec
left a comment
There was a problem hiding this comment.
One minor comment on the naming of eliminate_store_load, otherwise LGTM.
I'm curious if you lifted the dfg reference out of the context to address anything in particular or if it was a stylistic change?
joss-aztec
approved these changes
May 22, 2023
TomAFrench
added a commit
that referenced
this pull request
May 24, 2023
* master: chore(ssa refactor): Add loop unrolling pass (#1364) chore: Add terms added in ssa refactor to `cspell` (#1385) chore(ssa refactor): Optimize constant `jmpif`s into `jmp`s (#1374) feat: Allow warnings by default (#1383) chore(github): Update GitHub Pull Request Template (#1370) chore(github): Update GitHub Bug Report Template (#1368) chore(ssa refactor): Update mem2reg pass to work with multiple functions and blocks (#1375) chore(ssa refactor): Add pass to simplify the control flow graph (#1373) chore(github): Update GitHub Feature Request Template (#1369)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #
Description
Summary of changes
Previously the mem2reg pass relied on only operating on a single-block program so that it could remove stores properly. I've edited it so that it only removes stores after checking if the program is only one block. With this and some small changes to the entry it should now work on any program. I've also added a test with 2 blocks to test this.
Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Documentation needs
Additional context