fix(stdlib): Workaround for Field comparison error in EdDSA signature verification#1372
Merged
kevaundray merged 1 commit intonoir-lang:masterfrom May 18, 2023
Merged
fix(stdlib): Workaround for Field comparison error in EdDSA signature verification#1372kevaundray merged 1 commit intonoir-lang:masterfrom
kevaundray merged 1 commit intonoir-lang:masterfrom
Conversation
kevaundray
approved these changes
May 18, 2023
TomAFrench
added a commit
that referenced
this pull request
May 23, 2023
* phated/acvm-0.12.0: fix compilation issue switch to published acvm and backend feat(nargo): Consume CommonReferenceString functions & manage caching (#1348) fix(stdlib): Workaround for Field comparison error in EdDSA signature verification (#1372) feat!: remove concept of noir fallbacks for foreign functions (#1371) feat(ssa refactor): mem2reg opt pass (#1363) feat(stdlib): EdDSA sig verification (#1313)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Related to #1313
Description
This PR resolves an error that occurs when generating a proof involving EdDSA signature verification: Calling
eddsa_poseidon_verifyleads to an error on the following example:nargo testpasses, butnargo provewith the followingProver.tomlfails with the errornot implemented: Field comparison is not implemented yet, try to cast arguments to integer type:The problem lies in
lt_bytes32, where the compiler is not treating the elements of the byte arraysx_bytesandy_bytesas bytes. This PR adds type casts to force this, which eliminates the above error.Summary of changes
Added
u8type casts.Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Documentation needs
Additional context