Skip to content

chore: elaborator types.rs nits#10375

Merged
jfecher merged 8 commits intomasterfrom
ab/structs-and-types-refactors-and-comments
Nov 5, 2025
Merged

chore: elaborator types.rs nits#10375
jfecher merged 8 commits intomasterfrom
ab/structs-and-types-refactors-and-comments

Conversation

@asterite
Copy link
Collaborator

@asterite asterite commented Nov 5, 2025

Description

Problem

No issue.

Summary

This PR has some little changes that I thought were worth doing, while I was auditing this file. There might be more changes later on, but I thought this was a good stopping point.

Additional Context

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: a0b8aef Previous: 27c9f67 Ratio
test_report_zkpassport_noir-ecdsa_ 3 s 1 s 3

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@jfecher jfecher added this pull request to the merge queue Nov 5, 2025
Merged via the queue into master with commit dec5ef2 Nov 5, 2025
131 checks passed
@jfecher jfecher deleted the ab/structs-and-types-refactors-and-comments branch November 5, 2025 14:16
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Nov 6, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore(frontend): Loop control flow unit tests (noir-lang/noir#10387)
chore: Release Noir(1.0.0-beta.15) (noir-lang/noir#10125)
feat(doc): crate name, version, and dark mode (noir-lang/noir#10378)
chore(elaborator): Add `LoopStatement` (noir-lang/noir#10377)
chore(elaborator): Ensure that `push_location` and `push_type` cannot be forgotten (noir-lang/noir#10374)
feat: nargo doc (noir-lang/noir#10314)
chore: Add remaining doc comments to interpreter (noir-lang/noir#10368)
chore: green light for bn254_blackbox_solver audit (noir-lang/noir#10371)
chore: elaborator types.rs nits (noir-lang/noir#10375)
fix: do not replace return for databus (noir-lang/noir#10355)
END_COMMIT_OVERRIDE

Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Nov 6, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore(frontend): Loop control flow unit tests (noir-lang/noir#10387)
chore: Release Noir(1.0.0-beta.15) (noir-lang/noir#10125)
feat(doc): crate name, version, and dark mode (noir-lang/noir#10378)
chore(elaborator): Add `LoopStatement` (noir-lang/noir#10377)
chore(elaborator): Ensure that `push_location` and `push_type` cannot be forgotten (noir-lang/noir#10374)
feat: nargo doc (noir-lang/noir#10314)
chore: Add remaining doc comments to interpreter (noir-lang/noir#10368)
chore: green light for bn254_blackbox_solver audit (noir-lang/noir#10371)
chore: elaborator types.rs nits (noir-lang/noir#10375)
fix: do not replace return for databus (noir-lang/noir#10355)
END_COMMIT_OVERRIDE
github-merge-queue bot pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Nov 6, 2025
Automated pull of nightly from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore(frontend): Loop control flow unit tests
(noir-lang/noir#10387)
chore: Release Noir(1.0.0-beta.15)
(noir-lang/noir#10125)
feat(doc): crate name, version, and dark mode
(noir-lang/noir#10378)
chore(elaborator): Add `LoopStatement`
(noir-lang/noir#10377)
chore(elaborator): Ensure that `push_location` and `push_type` cannot be
forgotten (noir-lang/noir#10374)
feat: nargo doc (noir-lang/noir#10314)
chore: Add remaining doc comments to interpreter
(noir-lang/noir#10368)
chore: green light for bn254_blackbox_solver audit
(noir-lang/noir#10371)
chore: elaborator types.rs nits
(noir-lang/noir#10375)
fix: do not replace return for databus
(noir-lang/noir#10355)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants