Conversation
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: ae001a3 | Previous: 65a8fb0 | Ratio |
|---|---|---|---|
test_report_zkpassport_noir_rsa_ |
2 s |
1 s |
2 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 3384c75 | Previous: dbe4d81 | Ratio |
|---|---|---|---|
sha512-100-bytes |
0.087 s |
0.055 s |
1.58 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
|
I recently realized some types like |
|
I took a quick look at getting the dead link checking up but it seems like a lot of tools are just set up for markdown and supposedly a lot of the ones which work on html files aren't maintained or complete.
We can have a build of the stdlib docs pushed to gh_pages in a separate PR. |
7964948 to
ae001a3
Compare
Pull Request is not mergeable
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore(frontend): Loop control flow unit tests (noir-lang/noir#10387) chore: Release Noir(1.0.0-beta.15) (noir-lang/noir#10125) feat(doc): crate name, version, and dark mode (noir-lang/noir#10378) chore(elaborator): Add `LoopStatement` (noir-lang/noir#10377) chore(elaborator): Ensure that `push_location` and `push_type` cannot be forgotten (noir-lang/noir#10374) feat: nargo doc (noir-lang/noir#10314) chore: Add remaining doc comments to interpreter (noir-lang/noir#10368) chore: green light for bn254_blackbox_solver audit (noir-lang/noir#10371) chore: elaborator types.rs nits (noir-lang/noir#10375) fix: do not replace return for databus (noir-lang/noir#10355) END_COMMIT_OVERRIDE Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore(frontend): Loop control flow unit tests (noir-lang/noir#10387) chore: Release Noir(1.0.0-beta.15) (noir-lang/noir#10125) feat(doc): crate name, version, and dark mode (noir-lang/noir#10378) chore(elaborator): Add `LoopStatement` (noir-lang/noir#10377) chore(elaborator): Ensure that `push_location` and `push_type` cannot be forgotten (noir-lang/noir#10374) feat: nargo doc (noir-lang/noir#10314) chore: Add remaining doc comments to interpreter (noir-lang/noir#10368) chore: green light for bn254_blackbox_solver audit (noir-lang/noir#10371) chore: elaborator types.rs nits (noir-lang/noir#10375) fix: do not replace return for databus (noir-lang/noir#10355) END_COMMIT_OVERRIDE
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore(frontend): Loop control flow unit tests (noir-lang/noir#10387) chore: Release Noir(1.0.0-beta.15) (noir-lang/noir#10125) feat(doc): crate name, version, and dark mode (noir-lang/noir#10378) chore(elaborator): Add `LoopStatement` (noir-lang/noir#10377) chore(elaborator): Ensure that `push_location` and `push_type` cannot be forgotten (noir-lang/noir#10374) feat: nargo doc (noir-lang/noir#10314) chore: Add remaining doc comments to interpreter (noir-lang/noir#10368) chore: green light for bn254_blackbox_solver audit (noir-lang/noir#10371) chore: elaborator types.rs nits (noir-lang/noir#10375) fix: do not replace return for databus (noir-lang/noir#10355) END_COMMIT_OVERRIDE
Description
Problem
Will help with building aztec-nr docs, and any package docs in general.
Summary
This PR started as a new command to generate a JSON that would help build docs.
Then it produced a single Markdown file from that JSON output (or, well, from the Rust types representing that JSON).
Eventually, and this is the final form of this PR, it morphed into generating HTML files (with a stylesheet) to navigate the docs.
Here are example docs built from the aztec-nr repository: https://asterite.github.io/aztec-nr-docs/index.html
Features:
Note: the docs won't look very complete at this point but that's because aztec-nr lacks doc comments. There are some, but ideally every module and item is documented there, with examples, etc.
Additional Context
The large diff is because we now commit the generated stdlib docs.
Documentation
Check one:
PR Checklist
cargo fmton default settings.