chore: Add remaining doc comments to interpreter#10368
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 8034595 | Previous: 27c9f67 | Ratio |
|---|---|---|---|
private-kernel-inner |
0.016 s |
0.013 s |
1.23 |
rollup-checkpoint-merge |
0.004 s |
0.003 s |
1.33 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
TomAFrench
approved these changes
Nov 5, 2025
compiler/noirc_frontend/src/hir/comptime/interpreter/foreign.rs
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 8034595 | Previous: 27c9f67 | Ratio |
|---|---|---|---|
test_report_zkpassport_noir-ecdsa_ |
2 s |
1 s |
2 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Nov 6, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore(frontend): Loop control flow unit tests (noir-lang/noir#10387) chore: Release Noir(1.0.0-beta.15) (noir-lang/noir#10125) feat(doc): crate name, version, and dark mode (noir-lang/noir#10378) chore(elaborator): Add `LoopStatement` (noir-lang/noir#10377) chore(elaborator): Ensure that `push_location` and `push_type` cannot be forgotten (noir-lang/noir#10374) feat: nargo doc (noir-lang/noir#10314) chore: Add remaining doc comments to interpreter (noir-lang/noir#10368) chore: green light for bn254_blackbox_solver audit (noir-lang/noir#10371) chore: elaborator types.rs nits (noir-lang/noir#10375) fix: do not replace return for databus (noir-lang/noir#10355) END_COMMIT_OVERRIDE Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Nov 6, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore(frontend): Loop control flow unit tests (noir-lang/noir#10387) chore: Release Noir(1.0.0-beta.15) (noir-lang/noir#10125) feat(doc): crate name, version, and dark mode (noir-lang/noir#10378) chore(elaborator): Add `LoopStatement` (noir-lang/noir#10377) chore(elaborator): Ensure that `push_location` and `push_type` cannot be forgotten (noir-lang/noir#10374) feat: nargo doc (noir-lang/noir#10314) chore: Add remaining doc comments to interpreter (noir-lang/noir#10368) chore: green light for bn254_blackbox_solver audit (noir-lang/noir#10371) chore: elaborator types.rs nits (noir-lang/noir#10375) fix: do not replace return for databus (noir-lang/noir#10355) END_COMMIT_OVERRIDE
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Nov 6, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore(frontend): Loop control flow unit tests (noir-lang/noir#10387) chore: Release Noir(1.0.0-beta.15) (noir-lang/noir#10125) feat(doc): crate name, version, and dark mode (noir-lang/noir#10378) chore(elaborator): Add `LoopStatement` (noir-lang/noir#10377) chore(elaborator): Ensure that `push_location` and `push_type` cannot be forgotten (noir-lang/noir#10374) feat: nargo doc (noir-lang/noir#10314) chore: Add remaining doc comments to interpreter (noir-lang/noir#10368) chore: green light for bn254_blackbox_solver audit (noir-lang/noir#10371) chore: elaborator types.rs nits (noir-lang/noir#10375) fix: do not replace return for databus (noir-lang/noir#10355) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Summary*
Finishes adding doc comments to the remaining interpreter functions
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.