This repository was archived by the owner on Apr 9, 2024. It is now read-only.
feat(acvm)!: Support stepwise execution of ACIR#399
Merged
TomAFrench merged 16 commits intomasterfrom Jul 26, 2023
Merged
Conversation
2 tasks
TomAFrench
commented
Jun 21, 2023
TomAFrench
commented
Jun 21, 2023
2 tasks
TomAFrench
force-pushed
the
linear-acvm
branch
3 times, most recently
from
04599d4 to
fb5a924
Compare
Contributor
|
Is this dependent on #433 |
Member
Author
Only to create a new release and have Noir consume it. |
Co-authored-by: TomAFrench <tom@tomfren.ch> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
TomAFrench
commented
Jul 26, 2023
kevaundray
reviewed
Jul 26, 2023
Contributor
|
Hmm seems I left comments and github didn't save them 🤔 |
kevaundray
approved these changes
Jul 26, 2023
Contributor
kevaundray
left a comment
kevaundray
left a comment
There was a problem hiding this comment.
Spoke with Tom on slack, we can deal with these nits in a separate PR
Merged
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Janky implementation of stepwise execution.
Summary*
This PR makes the assumption that each opcode can be executed on the first attempt (excluding foreign calls). We can then implement stepwise execution.
Additional Context
PR Checklist*
cargo fmton default settings.