This repository was archived by the owner on Apr 9, 2024. It is now read-only.
feat(acvm)!: Remove OpcodeResolution enum#400
Merged
kevaundray merged 8 commits intomasterfrom Jul 26, 2023
Merged
Conversation
TomAFrench
force-pushed
the
linear-acvm
branch
2 times, most recently
from
57ae6eb to
925e84e
Compare
TomAFrench
force-pushed
the
remove-opcode-resolution
branch
from
b41eb13 to
fb900c0
Compare
TomAFrench
force-pushed
the
linear-acvm
branch
3 times, most recently
from
04599d4 to
fb5a924
Compare
TomAFrench
force-pushed
the
remove-opcode-resolution
branch
from
fb900c0 to
a3725ca
Compare
TomAFrench
force-pushed
the
remove-opcode-resolution
branch
from
2110f06 to
57ad06e
Compare
2 tasks
kevaundray
approved these changes
Jul 26, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Summary*
The assumption made in #399 that each opcode will be immediately executable means that we no longer need to track multiple different potential outcomes of an opcode - it either succeeds or fails. There's a slight special case with Brillig where it may require a foreign call but that's easy to handle.
Additional Context
PR Checklist*
cargo fmton default settings.