This repository was archived by the owner on Apr 9, 2024. It is now read-only.
feat!: ACVM no longer takes ownership over opcodes#558
Closed
TomAFrench wants to merge 2 commits intomasterfrom
Closed
feat!: ACVM no longer takes ownership over opcodes#558TomAFrench wants to merge 2 commits intomasterfrom
TomAFrench wants to merge 2 commits intomasterfrom
Conversation
TomAFrench
commented
Sep 20, 2023
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
With the changes in #399, the only reason that ACVM needs ownership over the circuit's opcodes is that it needs to be able to write the return values from foreign calls into the
Brilligopcodes. This doesn't really make sense as this is ACVM state rather than a property of the bytecode.I've then moved these into a hashmap held on the
ACVMstruct which get injected into the solver when we encounter a brillig opcode.Additional Context
PR Checklist*
cargo fmton default settings.