Skip to content
This repository was archived by the owner on Apr 9, 2024. It is now read-only.

feat!: ACVM no longer takes ownership over opcodes#558

Closed
TomAFrench wants to merge 2 commits intomasterfrom
tf/borrowed-opcodes-acvm
Closed

feat!: ACVM no longer takes ownership over opcodes#558
TomAFrench wants to merge 2 commits intomasterfrom
tf/borrowed-opcodes-acvm

Conversation

@TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

With the changes in #399, the only reason that ACVM needs ownership over the circuit's opcodes is that it needs to be able to write the return values from foreign calls into the Brillig opcodes. This doesn't really make sense as this is ACVM state rather than a property of the bytecode.

I've then moved these into a hashmap held on the ACVM struct which get injected into the solver when we encounter a brillig opcode.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant