src: ensure v8::Eternal is empty before setting it
#59825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V8 does not check this for us, but this is a requirement of the API.
nodejs-github-bot
added
c++
jasnell
approved these changes
Sep 9, 2025
github-actions
bot
removed
the
request-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59825 +/- ##
==========================================
+ Coverage 88.26% 88.28% +0.01%
==========================================
Files 701 701
Lines 206784 206784
Branches 39762 39765 +3
==========================================
+ Hits 182528 182559 +31
+ Misses 16304 16243 -61
- Partials 7952 7982 +30
🚀 New features to boost your workflow:
|
legendecas
approved these changes
Sep 9, 2025
juanarbol
approved these changes
Sep 9, 2025
addaleax
added
author ready
github-actions
bot
removed
the
request-ci
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 220baad |
|
@addaleax what's the difference between v8::Global and v8::Eternal? if you don't mind me asking... |
targos
pushed a commit
that referenced
this pull request
Sep 12, 2025
V8 does not check this for us, but this is a requirement of the API. PR-URL: #59825 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8 does not check this for us, but this is a requirement of the API.