Skip to content

Conversation

theanarkh
Copy link
Contributor

Refs: #59428

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/web-infra

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 10, 2025
@theanarkh theanarkh force-pushed the add_heap_profile_to_worker branch 2 times, most recently from c6bb954 to faf9b75 Compare September 10, 2025 17:08
@theanarkh theanarkh added semver-minor PRs that contain new features and should be released in the next minor version. worker Issues and PRs related to Worker support. labels Sep 10, 2025
@theanarkh theanarkh force-pushed the add_heap_profile_to_worker branch from faf9b75 to 616a9bd Compare September 10, 2025 17:41
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

❌ Patch coverage is 77.84091% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.28%. Comparing base (861d624) to head (616a9bd).

Files with missing lines Patch % Lines
src/node_worker.cc 76.11% 17 Missing and 15 partials ⚠️
lib/internal/worker.js 83.33% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #59846      +/-   ##
==========================================
+ Coverage   88.26%   88.28%   +0.01%     
==========================================
  Files         701      701              
  Lines      206774   206950     +176     
  Branches    39778    39808      +30     
==========================================
+ Hits       182514   182698     +184     
+ Misses      16298    16259      -39     
- Partials     7962     7993      +31     
Files with missing lines Coverage Δ
src/node_errors.h 87.50% <ø> (ø)
src/node_worker.h 91.66% <ø> (ø)
lib/internal/worker.js 96.51% <83.33%> (-0.86%) ⬇️
src/node_worker.cc 81.80% <76.11%> (-0.19%) ⬇️

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version. worker Issues and PRs related to Worker support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants