Skip to content

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Sep 10, 2025

Do not add a trailing slash if it was not removed by resolve in ToNamespacedPath.

Unfortunatelly I do not know how to test this without 3rd party tools descirbed in #58223.

Refs: #56110
Fixes: #58223

Do not add a trailing slash if it was not removed by resolve in
ToNamespacedPath.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Sep 10, 2025
@Flarna Flarna added the windows Issues and PRs related to the Windows platform. label Sep 10, 2025
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.27%. Comparing base (861d624) to head (f8fd082).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #59847      +/-   ##
==========================================
+ Coverage   88.26%   88.27%   +0.01%     
==========================================
  Files         701      701              
  Lines      206774   206774              
  Branches    39778    39779       +1     
==========================================
+ Hits       182514   182540      +26     
+ Misses      16298    16236      -62     
- Partials     7962     7998      +36     
Files with missing lines Coverage Δ
src/node_file.cc 75.63% <ø> (ø)

... and 44 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Flarna Flarna added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node 22 broke readdir on Windows UNC paths
2 participants