-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
async-hooks.test-emit-after-on-destroyed is flaky #50245
Comments
Seems to be a child process issue not async hooks. |
Usually the exit code being |
Similar test is flaky as well: #50262 |
Ref: #50245 PR-URL: #50246 Refs: #50245 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Ref: #50245 PR-URL: #50246 Refs: #50245 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Ref: nodejs#50245 PR-URL: nodejs#50246 Refs: nodejs#50245 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Ref: #50245 PR-URL: #50246 Refs: #50245 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Ref: #50245 PR-URL: #50246 Refs: #50245 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
I started to investigate this issue last week. I asked @mhdawson to spin up some stress tests ref: https://ci.nodejs.org/job/node-stress-single-test/nodes=rhel8-ppc64le/469/console We ran this test case 1000 times on rhel8 ppc64le. This did not reproduce the error though. I then built Node.js 21.0.0 (The version of node at the time of the issue) on my local machine (Fedora 39). From there I ran this test 100k times and I still was not able to reproduce a test failure. $ tools/test.py -j 16 --repeat=100000 async-hooks/test-emit-after-on-destroyed
[14:17|% 100|+ 100000|- 0]: Done
All tests passed.
As noted before in #50245 (comment), the failure occurs due to a signal be raised but will need find a way to reproduce the failure to get more info on the signal and why the test case is getting signaled. Any further suggestions on how to reproduce the error? Maybe it occurs more when running all the test cases together? OR Maybe it presents itself more frequently on some platforms? The original issue indicates it occurred on ppc64 AIX. Maybe stress testing AIX would reproduce the error. |
@abmusse I think trying the stress test on one of the platforms where we saw the failure makes sense. I think that @richardlau mentioned you still have access to one of the AIX machines from an earlier investigation so trying the 100k run there would be a good next step. |
Today I ran 100k stress test on one our AIX machines. $ tools/test.py --repeat=100000 async-hooks/test-emit-after-on-destroyed
[59:37|% 100|+ 100000|- 0]: Done Running it 100k times on AIX didn't reproduce the error. |
I suggest we un-mark this test as flaky as running it 100k times did not reproduce the error. I will keep an eye on it and if it returns to a flaky state will handle marking it as flaky again. |
I tested running the test case 100k times on the AIX ci machine and was unable to re-produce the error. Also it has not showed up recently as flaky on the ci. I suggest we mark this as un-flaky. ref: #50245 (comment) PR-URL: #51995 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
I tested running the test case 100k times on the AIX ci machine and was unable to re-produce the error. Also it has not showed up recently as flaky on the ci. I suggest we mark this as un-flaky. ref: nodejs#50245 (comment) PR-URL: nodejs#51995 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Ref: nodejs/node#50245 PR-URL: nodejs/node#50246 Refs: nodejs/node#50245 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Ref: nodejs/node#50245 PR-URL: nodejs/node#50246 Refs: nodejs/node#50245 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
I tested running the test case 100k times on the AIX ci machine and was unable to re-produce the error. Also it has not showed up recently as flaky on the ci. I suggest we mark this as un-flaky. ref: #50245 (comment) PR-URL: #51995 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
I tested running the test case 100k times on the AIX ci machine and was unable to re-produce the error. Also it has not showed up recently as flaky on the ci. I suggest we mark this as un-flaky. ref: nodejs#50245 (comment) PR-URL: nodejs#51995 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Test
async-hooks.test-emit-after-on-destroyed
Platform
Other
Console output
Build links
Additional information
No response
The text was updated successfully, but these errors were encountered: