Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools,doc: fix commit message using test instead of deps #46313

Merged
merged 5 commits into from
Jan 27, 2023
Merged

tools,doc: fix commit message using test instead of deps #46313

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
14c9c16
doc: fix commit message using test instead of deps
tony-go Jan 23, 2023
9f20e4d
doc: reformat md
tony-go Jan 23, 2023
4135364
ci: change label and subsystem
tony-go Jan 23, 2023
c855f2f
doc: fix formatting issues
tony-go Jan 23, 2023
37df3c7
doc: fix indentation for nested text snippet
tony-go Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/tools.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ jobs:
./tools/update-undici.sh
fi
- id: postject
subsystem: deps
label: dependencies
subsystem: test
label: test
run: |
NEW_VERSION=$(npm view postject dist-tags.latest)
CURRENT_VERSION=$(node -p "require('./test/fixtures/postject-copy/node_modules/postject/package.json').version")
Expand Down
8 changes: 4 additions & 4 deletions doc/contributing/maintaining-postject.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ Check that Node.js still builds and tests.

## Committing postject

Add postject: `git add --all test/fixtures/postject-copy`

Commit the changes with a message like:
1. Add postject: `git add --all test/fixtures/postject-copy`.
2. Commit the changes: `git commit`.
3. Add a message like:

```text
deps: update postject to 1.0.0-alpha.4
test: update postject to <version>

Updated as described in doc/contributing/maintaining-postject.md.
```
tony-go marked this conversation as resolved.
Show resolved Hide resolved