V5.4.1 propose #4626

General improvements to crypto.markdown including new and revised examples. PR-URL: #4435 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>

PR-URL: #4549 Reviewed-By: Colin Ihrig <[email protected]>

Refs: #3254 PR-URL: #4540 Reviewed-By: James M Snell <[email protected]>

Adds Myles Borins and his public key to the README PR-URL: #4578 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Evan Lucas <[email protected]>

Adds Evan Lucas and his public key to the README for releases PR-URL: #4579 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>

It avoids the creation of unnecessary handles. This issue is causing intermitent failures in `test-cluster-disconnect-race` on `FreeBSD` and `OS X`. The problem is that the `worker2.disconnect` is being called on the master before the `queryServer` is handled, causing the worker to be deleted, then the Server handle is created afterwards. Later on, when `removeWorker` is called from the `exit` handler, there are no workers left, but one handle, thus the `AssertionError`. Add a new `test/sequential/test-cluster-disconnect-leak` based on `test-cluster-disconnect-race` that creates lots of workers and fails consistently without this patch. PR-URL: #4465 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Rich Trott <[email protected]>

fix description about the latest LTS release download page to make it clear PR-URL: #4583 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>

`V4MAPPED` isn't supported by Android either (as of 6.0) PR-URL: #4580 Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

Missed on the previous review, minor line wrapping nit PR-URL: #4588 Reviewed-By: Colin Ihrig <[email protected]>

The server method returns `self` in order to allow chaining. PR-URL: #4590 Fixes: #4571 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>

`Server`, `ServerResponse` etc. were marked as classes, this one class was overlooked. PR-URL: #4589 Fixes: #4576 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Reiss <[email protected]>

Fixes: #4532 PR-URL: #4535 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Roman Reiss <[email protected]>

Remove unnecessary `setImmediate()` that causes a minor race condition. Stop the test after 3 occurrences rather than 5 to allow for slower hosts running the test in parallel with other tests. Fixes: #4559 PR-URL: #4599 Reviewed-By: Johan Bergström <[email protected]>

PR-URL: #4617 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]>

- Changed colors to match frontpage as close as possible. - Links are slightly more horizontally padded as compared before to accomodate for the hover effect. - Slightly reduced the scroll indication height on the TOC. - The main content is now offset using margin instead of the previous border hack. - remove empty footer that was rendering a dark bar on the bottom of each page without any content. PR-URL: #4621 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>

The docs were recently refactored, and some "above" and "below" references were no longer accurate. This commit removes many such references, and replaces others with links. PR-URL: #4499 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>

A few tests in test/gc include the http module twice. Remove duplicate require(). PR-URL: #4606 Reviewed-By: Brian White <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>

The exts and trailingSlash variables are only used if the path isn't cached. This commit moves them further down in the code, and changes from var to const. PR-URL: #3579 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Two tests were requiring the common module twice. This removes the duplicate require statement in the tests. PR-URL: #4611 Reviewed-By: Brian White <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]>

Remove redeclarations of variables in node.js. This includes removing one apparently unnecessary `NativeModule.require('module')`. PR-URL: #4605 Reviewed-By: Brian White <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]>

In lib/_http_client.js, the variable `conn` was declared with the `var` keyword three times in the same scope. This change eliminates the variable entirely. PR-URL: #4612 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>

In order to make developers aware of node-core built-in functionality, which might replace module APIs, we should add an example of readline`s interface usage. SEO will eventually aid this goal, since it is well searched on Q&A sites. PR-URL: #4609 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]>>

Do not attempt to read data from the socket whilst on OpenSSL's stack, weird things may happen, and this is most likely going to result in some kind of error. PR-URL: #4624 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: James M Snell <[email protected]>

This comment was added with an assumption that we could determine the IP address that localhost should resolve to without performing a lookup. This was a false assumption and should be removed. PR-URL: #4648 Reviewed-By: Brian White <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

`fork` is imported twice in a row. Remove duplication. PR-URL: #4634 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Notable Changes: * Minor performance improvements: - module: move unnecessary work for early return (Andres Suarez) #3579 * Various bug fixes * Various doc fixes * Various test improvements PR-URL: #4626

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V5.4.1 propose #4626

V5.4.1 propose #4626

Commits on Jan 12, 2016