-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix description about the latest-codename #4583
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix description about the latest LTS release download page to make it clear
I guess this was my stuff-up, thanks for fixing, lgtm |
LGTM |
1 similar comment
LGTM |
@JungMinu ... quick nit.. not sure if you noticed but you created the branch for this in the main nodejs/node repo. We want to try to avoid folks creating branches in the main repo for PRs. |
JungMinu
added a commit
that referenced
this pull request
Jan 8, 2016
fix description about the latest LTS release download page to make it clear PR-URL: #4583 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Landed in fde18b2 |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 11, 2016
fix description about the latest LTS release download page to make it clear PR-URL: #4583 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
@jasnell sorry, it was a mistake |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 12, 2016
fix description about the latest LTS release download page to make it clear PR-URL: #4583 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
No worries @JungMinu :-) I've done it before too |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 13, 2016
fix description about the latest LTS release download page to make it clear PR-URL: #4583 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 14, 2016
fix description about the latest LTS release download page to make it clear PR-URL: #4583 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 14, 2016
fix description about the latest LTS release download page to make it clear PR-URL: #4583 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
fix description about the latest LTS release download page to make it clear PR-URL: #4583 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
fix description about the latest LTS release download page to make it clear PR-URL: nodejs#4583 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix description about the latest LTS release download page
to make it clear