-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: bring releases.md up to date #4540
Conversation
``` | ||
|
||
### 4. Update _src/node_version.h_ | ||
The release type should be either Stable, LTS, or Maintenance, depending on the type of release being produced. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should likely note that only the LTS WG can cut LTS releases and that there is a slightly modified process that uses the various -staging
branches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasnell since the audience for this document is the release and LTS team members, and I'm not totally up to speed on the LTS release process, would you be OK with adding the LTS specific info in a subsequent PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, not a problem!
Only performed a cursory look through but generally LGTM |
Refs: #3254 PR-URL: #4540 Reviewed-By: James M Snell <[email protected]>
Thanks for the review. Landed in f1653cc. |
Refs: #3254 PR-URL: #4540 Reviewed-By: James M Snell <[email protected]>
Refs: #3254 PR-URL: #4540 Reviewed-By: James M Snell <[email protected]>
Refs: #3254 PR-URL: #4540 Reviewed-By: James M Snell <[email protected]>
Refs: #3254 PR-URL: #4540 Reviewed-By: James M Snell <[email protected]>
Refs: #3254 PR-URL: #4540 Reviewed-By: James M Snell <[email protected]>
Refs: #3254 PR-URL: #4540 Reviewed-By: James M Snell <[email protected]>
Refs: nodejs#3254 PR-URL: nodejs#4540 Reviewed-By: James M Snell <[email protected]>
This commit brings the release procedure documentation up to date. I tried to consolidate the material in the existing
releases.md
with #3254 and #4384 (comment).Refs: #3254
R= @nodejs/release