Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: ask more questions in the bug report template #31611

Closed
wants to merge 2 commits into from
Closed

doc: ask more questions in the bug report template #31611

wants to merge 2 commits into from

Conversation

joyeecheung
Copy link
Member

Inspired by the defect report template of the V8 issue tracker

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@joyeecheung
doc: ask more questions in the bug report template
fda37e2 
Inspired by the defect report template of the V8 issue tracker
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Feb 2, 2020
Trott
Trott approved these changes Feb 2, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I default to not wanting to make these templates longer, but I think the "steps to reproduce", "expected results", and "what you see instead" stuff has become pretty standard and people will immediately know what it is. LGTM. Thanks!

joyeecheung added a commit that referenced this pull request Feb 6, 2020
@joyeecheung
doc: ask more questions in the bug report template
0effc98 
Inspired by the defect report template of the V8 issue tracker

PR-URL: #31611
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@joyeecheung
Copy link
Member Author

Landed in 0effc98

@joyeecheung joyeecheung closed this Feb 6, 2020
@joyeecheung joyeecheung mentioned this pull request Feb 6, 2020
Closed
4 tasks
@joyeecheung
Copy link
Member Author

Just noticed that this change is not in effect because it changed the obsolete .github/ISSUE_TEMPLATE.md while the file in effect is .github/ISSUE_TEMPLATE/1-bug-report.md. Opened #31656

Trott pushed a commit that referenced this pull request Feb 7, 2020
@joyeecheung @Trott
doc: remove .github/ISSUE_TEMPLATE.md in favor of the template folder
e2a3a87 
This removes the obsolete issue template file since we already
have the issue template folder which is the one currently in effect.

PR-URL: #31656
Refs: #31611
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@joyeecheung @codebytere
doc: ask more questions in the bug report template
e27f249 
Inspired by the defect report template of the V8 issue tracker

PR-URL: #31611
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@joyeecheung @codebytere
doc: remove .github/ISSUE_TEMPLATE.md in favor of the template folder
2e6c737 
This removes the obsolete issue template file since we already
have the issue template folder which is the one currently in effect.

PR-URL: #31656
Refs: #31611
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@joyeecheung @codebytere
doc: ask more questions in the bug report template
73c0986 
Inspired by the defect report template of the V8 issue tracker

PR-URL: #31611
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@joyeecheung @codebytere
doc: remove .github/ISSUE_TEMPLATE.md in favor of the template folder
44235db 
This removes the obsolete issue template file since we already
have the issue template folder which is the one currently in effect.

PR-URL: #31656
Refs: #31611
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@joyeecheung @codebytere
doc: ask more questions in the bug report template
ea4f266 
Inspired by the defect report template of the V8 issue tracker

PR-URL: #31611
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@joyeecheung @codebytere
doc: remove .github/ISSUE_TEMPLATE.md in favor of the template folder
aeadd68 
This removes the obsolete issue template file since we already
have the issue template folder which is the one currently in effect.

PR-URL: #31656
Refs: #31611
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@joyeecheung @codebytere
doc: ask more questions in the bug report template
afeaec7 
Inspired by the defect report template of the V8 issue tracker

PR-URL: #31611
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@joyeecheung @codebytere
doc: remove .github/ISSUE_TEMPLATE.md in favor of the template folder
76b5002 
This removes the obsolete issue template file since we already
have the issue template folder which is the one currently in effect.

PR-URL: #31656
Refs: #31611
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@watilde watilde watilde approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@starkwang starkwang starkwang approved these changes

Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.