Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v16.6.0 proposal #39534

Merged
merged 117 commits into from
Jul 29, 2021
Merged

v16.6.0 proposal #39534

merged 117 commits into from
Jul 29, 2021

Conversation

BethGriggs
Copy link
Member

@BethGriggs BethGriggs commented Jul 26, 2021

Release date and notable changes TBD.


2021-07-29, Version 16.6.0 (Current), @BethGriggs

This is a security release.

Notable Changes

Say hello to V8 9.2

The V8 engine is updated to version 9.2.230.21.

It notably introduces the new Array.prototype.at method:

const array = [1, 2, 3];

console.log(array.at(-1));
// Prints: 3

Contributed by Michaël Zasso - #39470

Other notable changes

Commits

jasnell and others added 5 commits July 17, 2021 12:29
Refs: #39368
Signed-off-by: James M Snell <[email protected]>

PR-URL: #39369
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Fixup the definitions of the properties to avoid the possibility
of prototype polution on the object definitions.

Signed-off-by: James M Snell <[email protected]>

PR-URL: #39371
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
* Replace _PR_ with Pull Request
* Make some content more concise

PR-URL: #39359
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
For lint exceptions that are universal or near universal for
`test/common`, put the exceptions in a config file rather than disabling
the ESLint rules at the top of each file.

PR-URL: #39358
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
GYP uses the system path when parsing node.gyp;
However, if system python is different from our
gyp runtime python, like '2.7', gyp would crash.

Co-authored-by: Michaël Zasso <[email protected]>

PR-URL: #39293
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@BethGriggs BethGriggs added the wip Issues and PRs that are still a work in progress. label Jul 26, 2021
@nodejs-github-bot
Copy link
Collaborator

@targos
Copy link
Member

targos commented Jul 27, 2021

I pushed a suggestion for the changelog

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. v16.x labels Jul 27, 2021
@ronag
Copy link
Member

ronag commented Jul 27, 2021

stream: add readableDidRead (Robert Nagy) #36820

Might need a correction if it's to be included: #39543

EDIT: I would wait with including #36820 until #39543 has been discussed.

@BethGriggs
Copy link
Member Author

BethGriggs commented Jul 27, 2021

Thanks @ronag, I'll back out #36820 when I refresh the proposal later (still waiting on some other commits).

Trott and others added 15 commits July 29, 2021 11:56
find-inactive-collaborators.mjs works fine with Node.js 16.x, but GitHub
Actions currently use 14.x by default.

PR-URL: #39362
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
GitHub Action workflows can be told to clone a certain number of commits
or else everything. Change find-inactive-collaborators to take a number
of commits to examine rather than a date range so that the parameter can
be used in GitHub Actions.

PR-URL: #39362
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
In email, John-David Dalton confirmed that it was appropriate to move to
emeritus at this time.

PR-URL: #39380
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: John-David Dalton <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Experimental as part of the web streams implementation

Signed-off-by: James M Snell <[email protected]>

PR-URL: #39347
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
commit-lint.yml uses setup-node@v1 but all our other GitHub Actions use
v2. Update commit-lint.yml.

PR-URL: #39366
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #39367
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Add `process.setSourceMapsEnabled` to enable
source-maps programmatically.

PR-URL: #39085
Reviewed-By: Ben Coe <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #39391
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: #39175
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Signed-off-by: James M Snell <[email protected]>

PR-URL: #39331
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Makes the FileHandle::ClosePromise() idempotent, always returning
the same Promise after it has already been successfully called
once. Avoids the possibility of accidental double close events.

Signed-off-by: James M Snell <[email protected]>

PR-URL: #39331
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
All other files in `lib/internal` do not start with `_`. For
consistency, move `lib/internal/debugger/_inspect.js` to
`lib/internal/debugger/inspect.js`.

PR-URL: #39378
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sometimes we capitalize _collaborator_ and sometimes not. After
consulting the Microsoft Style Guide and The Chicago Manual of Style,
I've concluded it is best to not capitalize it. For consistency, apply
that to our various .md files.

Refs: https://docs.microsoft.com/en-us/style-guide/capitalization

PR-URL: #39379
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This commit adds instructions for adding machine-readable json files to
the security-wg repo in the security release guide.

PR-URL: #39220
Reviewed-By: James M Snell <[email protected]>
targos and others added 8 commits July 29, 2021 17:14
Original commit message:

    [mips][wasm][liftoff] Fix compile failed

    Port 2b77ca200c56667c68895e49c96c10ff77834f09

    Bug: v8:11809

    Change-Id: Idbbbc10d1339d6c8463686b6e701fb601a217cab
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2931557
    Reviewed-by: Zhao Jiazhong <[email protected]>
    Commit-Queue: Zhao Jiazhong <[email protected]>
    Auto-Submit: Liu yu <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#74934}

Refs: v8/v8@5c76da8

PR-URL: #39337
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
gtest_prod.h is not enough to build V8's cctests.

Backport-PR-URL: #39470
PR-URL: #38990
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Revert "[api] Avoid handles for const API functions"
This reverts commit aee471b2ff5b1a9e622426454885b748d226535b.

Revert "[api] Remove deprecated [Shared]ArrayBuffer API"
This reverts commit 578f6be77fc5d8af975005c2baf918e7225abb62.

Revert "[Jobs]: Cleanup in v8 platform."
This reverts commit baf2b088dd9f585aa597459f30d71431171666e2.

Revert "Skip global registration of [Shared]ArrayBuffer backing stores"
This reverts commit fcdf35e6d70d51699ece063e25dc705e80673308.

Revert "[api] Remove previously deprecated Function::GetDisplayName()."
This reverts commit 6165fef8cc9dde52973e54c915e6905221b3f8fb.

Revert "[api] Remove deprecated Symbol::Name()"
This reverts commit bbc72ef6c7d6d8e2c4dd074d7713e5c841003163.

Revert API change for HeapProfiler::TakeHeapSnapshot
This reverts a small part of 7f52e4f92d3d3ded9a1701ee2f93966075ae5004.

Revert "[cpu-profiler] Reintroduce support for context filtering"
This reverts commit 0aacfb2a6ecbeda1d1d97ca113afd8253a1b9670.

Restore new argument for TakeHeapSnapshot method
This creates a new TakeHeapSnapshotV8_92 method with the signature from
7f52e4f92d3d3ded9a1701ee2f93966075ae5004.
It is necessary because the API is used internall by V8.

Silence irrelevant warning
V8 triggers it in the Name method.

Revert "[api] Add v8::metrics::LongTaskStats for the LongTasks UKM"
This reverts commit 521ae93bf652b0cc1fec1fdd788e3b80fb72a349.

Move cage_base isolate data field
Makes 3ada6f27404b4ffd6d3e97cf15be76672f60c10d ABI-compatible.

PR-URL: #39470
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Refs: v8/v8@edac496

PR-URL: #39470
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
In email, Saúl indicated that they've switched to using their
personalized domain email address.  Update their email in README
accordingly. This will align their email in the README with their email
in .mailmap, which will in turn assist the accuracy of tools for
contributor metrics.

PR-URL: #39511
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
The previous Perl script used to generate the AUTHORS file (probably)
needed more entries than the current JS script to avoid duplicate
entries in AUTHORS. The entry removed here is no longer needed for that
purpose, but it is creating a small issue around tooling for gathering
contributor metrics.

PR-URL: #39512
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Per instructions from Fedor, I'm updating their email address in the
README.

PR-URL: #39510
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: James M Snell <[email protected]>
All of our workflows use Node.js 14.x or 16.x except for commit-lint.yml
which has 12.x hard-coded. Update it to 14.x and change it to using an
environment variable so it is consistent with our other workflows.

PR-URL: #39506
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs
Copy link
Member Author

radium failure in CITGM looks new: e.g. https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2733/nodes=rhel7-s390x/testReport/junit/(root)/citgm/radium_v0_26_1/

I can confirm reverting 10f1a85 fixes it - I will just revert it from this release while we figure out the issue as I don't want to hold up this release.

This is a security release.

Notable Changes:

- CVE-2021-22930: Use after free on close http2 on stream canceling
  (High) [#39423](#39423)
- (SEMVER-MINOR) deps: update V8 to 9.2.230.21 (Michaël Zasso)
  [#39470](#39470)
- inspector: mark as stable (Gireesh Punathil)
  [#37748](#37748)
- punycode: add pending deprecation (Antoine du Hamel)
  [#38444](#38444)
- (SEMVER-MINOR) repl: enable --experimental-repl-await /w opt-out
  (hemanth.hm) [#34733](#34733)

PR-URL: #39534
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 29, 2021

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 29, 2021

@BethGriggs BethGriggs merged commit 8d2e66c into v16.x Jul 29, 2021
BethGriggs added a commit that referenced this pull request Jul 29, 2021
BethGriggs added a commit that referenced this pull request Jul 29, 2021
This is a security release.

Notable Changes:

- CVE-2021-22930: Use after free on close http2 on stream canceling
  (High) [#39423](#39423)
- (SEMVER-MINOR) deps: update V8 to 9.2.230.21 (Michaël Zasso)
  [#39470](#39470)
- inspector: mark as stable (Gireesh Punathil)
  [#37748](#37748)
- punycode: add pending deprecation (Antoine du Hamel)
  [#38444](#38444)
- (SEMVER-MINOR) repl: enable --experimental-repl-await /w opt-out
  (hemanth.hm) [#34733](#34733)

PR-URL: #39534
BethGriggs added a commit to BethGriggs/nodejs.org that referenced this pull request Jul 29, 2021
BethGriggs added a commit to nodejs/nodejs.org that referenced this pull request Jul 29, 2021
@BethGriggs BethGriggs deleted the v16.6.0-proposal branch July 29, 2021 23:57
@targos targos added release Issues and PRs related to Node.js releases. and removed wip Issues and PRs that are still a work in progress. doc Issues and PRs related to the documentations. build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. labels Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.