-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update V8 to 8.6 #35415
deps: update V8 to 8.6 #35415
Conversation
If CI is green, I will work on releasing the |
@nodejs/v8-update |
LGTM |
important changes since v8 8.4:
|
New error on ARM64 Windows:
|
And on ia32:
|
/cc @nodejs/platform-windows |
@richard-townsend-arm any thought on this one ? I tried some fix, but still not work. cc @nodejs/platform-arm |
Yeah, this is the one of the potential issues I mentioned about compiler health at #25998 (comment) TL;DR is that there's nobody (apart from Node.js) that's advocating for supporting the MSVC build for Windows on Arm, and without any movement from upstream, it will get more and more difficult to maintain. Microsoft (at least) does care about the Clang build, so I'd recommend switching this platform's compiler in the long run. I can try and find some time to identify the fix for 8.6. |
@richard-townsend-arm I agree that being able to build with Clang on Windows would be very interesting. I experimented with it some time ago and was blocked on an issue with ICU: #34201 |
Looks like related to template on arm build, if the related code are commented on arm. D:\a\node\node\deps\v8\src\base\functional.h(142,1): error C2665: 'v8::internal::compiler::hash_value': none of the 36 overloads could convert all the argument types [D:\a\node\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
D:\a\node\node\deps\v8\src\compiler\machine-operator.h(191,8): message : could be 'size_t v8::internal::compiler::hash_value(v8::internal::compiler::ShiftKind)' [found using argument-dependent lookup] [D:\a\node\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj] |
Two things: Typo in mips config
Typo in windows arm64 generator
This lead to misconfig in
|
Update: Based on #35415 |
I have found fix and now back to #35415 (comment). I believe I found potential issue ... give me some time :) |
Ok, now I have reach #35415 (comment) without reverting v8 commit. I am not familiar with snapshot for now, don't know who to @ . Maybe @addaleax @joyeecheung I see v8 8.6 changed part of C:\Users\runneradmin\Desktop\node\out\Release\obj\v8_snapshot\embedded.S(278): error A2034: unknown opcode: Builtins_RecordWrite [C:\Users\runner
admin\Desktop\node\tools\v8_gypfiles\v8_snapshot.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\VC\v160\BuildCustomizations\marmasm.targets(70,5): error MSB3721
: The command "armasm64.exe ..\..\out\Release\obj\v8_snapshot\\embedded.S -o "..\..\out\Release\obj\v8_snapshot\embedded.obj" " exited with code
1. [C:\Users\runneradmin\Desktop\node\tools\v8_gypfiles\v8_snapshot.vcxproj] |
@gengjiawen Not sure until I see what's in |
@joyeecheung This occurred when we build V8 8.6 arm64 on windows. We have have fix many issues on gyp, not sure related to this. The @targos you may want to take a look at arm64 generator in #35415 (comment). |
I switched to v8 8.5, and found the generated config still is Maybe the new error is due to some linking issue. (The symbol exists in v8_base_without_compiler_host.lib(stack.obj) : error LNK2019: unresolved external symbol PushAllRegistersAndIterateStack referenced in function "public: void __cdecl heap::base::Stack::IteratePointers(class heap::base::StackVisitor *)const " (?IteratePointers@Stack@base@heap@@QEBAXPEAVStackVisitor@23@@Z) [D:\a\node\node\tools\v8_gypfiles\mksnapshot_host.vcxproj]
..\..\out\Release\mksnapshot_host.exe : fatal error LNK1120: 1 unresolved externals [D:\a\node\node\tools\v8_gypfiles\mksnapshot_host.vcxproj] |
PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: #35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: #40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: #40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: #38807 Refs: #38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: #35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: #40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: #40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: #38807 Refs: #38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: nodejs#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs#38807 Refs: nodejs#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
PR-URL: nodejs/node#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs/node#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs/node#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs/node#38807 Refs: nodejs/node#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
No description provided.