tools: adjust script for use with 14.x

[Trott]

find-inactive-collaborators.mjs works fine with Node.js 16.x, but GitHub
Actions currently use 14.x by default. This PR makes a small adjustment
so that it works with 14.x. (14.x does not accept URL objects as
paramemters for the cwd option in spawn().)

[targos]

Why not use 16.x in the action? This will never be run with node.js 14

[Trott]

Why not use 16.x in the action? This will never be run with node.js 14

I don't understand what you mean by "This will never be run with node.js 14". It runs with 14.x right now in the GitHub Action because that is the version that comes installed by default in GitHub Actions. https://github.com/nodejs/node/runs/3043788212?check_suite_focus=true I think I'm misunderstanding what you mean.

As for the question, though: If I add a step to the YAML workflow to install Node.js 16, then it will work, of course, and that was my first impulse. I went with this change instead for two reasons.

First, it's less overhead--just a small change to a script rather than downloading and installing Node.js every time (which is a slightly bigger but still small change to the YAML config but more "work" for the GitHub host).

Second, this doesn't require any further updates in the future, and if we do update it, it's really just a single straightforward update: remove the property added here. If we go with using setup-node to install Node.js 16, then we will need to change setup-node at some point or else eventually be running an EOL version of Node.js. I guess that's not exactly the end of the world, but on top of that, the possible changes are many. We could update the action to install a later version of Node.js, we could remove the installation of a newer version and go back to using the default version in the OS image used by GitHub Actions, we could switch to lts/*, etc.

So this seemed like a smaller temporary change with a more obvious path of what to do when it is no longer needed, and smaller downside if we never undo it.

[targos]

I don't understand what you mean by "This will never be run with node.js 14". It runs with 14.x right now in the GitHub Action because that is the version that comes installed by default in GitHub Actions.

I should have added "if we do it (use 16.x in the action)".

more "work" for the GitHub host

A very smaller amount of work. The host usually doesn't need to download anything because GitHub runners have common Node.js versions in cache.

If we go with using setup-node to install Node.js 16, then we will need to change setup-node at some point or else eventually be running an EOL version of Node.js

It's true, but we will already need to do it for other existing workflows

In general, I prefer to have control on the versions of software that are used in CI, instead of relying on defaults.
Those are just my opinions, I'm fine with whatever lands.

[Trott]

In general, I prefer to have control on the versions of software that are used in CI, instead of relying on defaults.

I don't feel strongly about it, so I'll go ahead and change this to a workflow adjustment instead.

[aduh95]

LGTM with or without my suggestion.

[Trott]

Landed in efd40ea...1bb660e