Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools,doc: forbid CJS globals in ESM code snippets #38889

Merged
merged 2 commits into from
Jun 3, 2021
Merged

tools,doc: forbid CJS globals in ESM code snippets #38889

merged 2 commits into from
Jun 3, 2021

Commits on Jun 3, 2021

  1. doc: fix .mjs syntax in crypto.md 

    Co-authored-by: Antoine du Hamel <[email protected]>

PR-URL: nodejs#38882
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
    @himself65 @aduh95
    himself65 authored and aduh95 committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    47548d0 View commit details
    Browse the repository at this point in the history

  2. tools,doc: forbid CJS globals in ESM code snippets 

    PR-URL: nodejs#38889
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
    @aduh95
    aduh95 committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    2481fac View commit details
    Browse the repository at this point in the history