build: use gh cli in workflows file #40985

Mesteery · 2021-11-26T20:56:52Z

No description provided.

Mesteery · 2021-11-26T20:57:42Z

Waiting the next release of GitHub CLI for cli/cli@1eb790c.

aduh95

You forgot to filter the label it seems.

.github/workflows/auto-start-ci.yml

.github/workflows/commit-queue.yml

Mesteery · 2021-11-27T09:53:02Z

You forgot to filter the label it seems.

Ah indeed, thank you!

.github/workflows/commit-queue.yml

aduh95 · 2021-11-27T11:15:23Z

Is it both blocked and author ready? That seems contradictory.

Mesteery · 2021-11-27T11:19:19Z

Is it both blocked and author ready? That seems contradictory.

For me it does not seem contradictory, there is also #38889 for example.

Description of author ready:

PRs that have at least one approval, no pending requests for changes, and a CI started.

Mesteery · 2021-12-14T18:17:24Z

GitHub CLI 2.3.0 is now available in GitHub Actions runners.

.github/workflows/comment-labeled.yml

Co-authored-by: Antoine du Hamel <[email protected]>

nodejs-github-bot · 2021-12-14T19:06:37Z

Landed in f404cd5

Trott · 2021-12-14T21:42:27Z

Is it at all possible that this broke the label-commenting workflow? Or maybe it was already broken? (Or maybe I don't understand how it's supposed to work?) After this landed, I labeled #14086 with stalled but no comment has been posted there yet from the workflow.

Trott · 2021-12-14T21:43:46Z

https://github.com/nodejs/node/runs/4525021875?check_suite_focus=true

Run gh pr comment "$NUMBER" --repo nodejs/node --body "This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open."
  gh pr comment "$NUMBER" --repo nodejs/node --body "This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open."
  shell: /usr/bin/bash -e {0}
  env:
    NUMBER: 14086
    GITHUB_TOKEN: ***
GraphQL: Could not resolve to a PullRequest with the number of 14086. (repository.pullRequest)
Error: Process completed with exit code 1.

Refs: nodejs#40985 (comment)

Mesteery · 2021-12-14T21:49:34Z

Ah, sorry, commenting on PRs and issues only works with gh issue comment.

Improve issue comment re: overfetching, handling PRs

cli/cli@1eb790c

Refs: #40985 (comment) PR-URL: #41176 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Trott · 2021-12-15T22:08:19Z

I'm not sure if this wasn't the case before this PR, but it looks like Commit Queue is failing when there are no PRs for it to land. I would expect it to succeed in that case. Example: https://github.com/nodejs/node/runs/4540327006?check_suite_focus=true

Because the last command is a gh command, I'm guessing this PR might have had something to do with it, but I could be wrong.

Refs: nodejs#40985 (comment)

PR-URL: #40985 Reviewed-By: Antoine du Hamel <[email protected]>

Refs: #40985 (comment) PR-URL: #41176 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Refs: nodejs#40985 (comment)

PR-URL: #40985 Reviewed-By: Antoine du Hamel <[email protected]>

Refs: #40985 (comment) PR-URL: #41176 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Refs: #40985 (comment) PR-URL: #41193 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>

PR-URL: #40985 Reviewed-By: Antoine du Hamel <[email protected]>

Refs: #40985 (comment) PR-URL: #41176 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rich Trott <[email protected]>

PR-URL: #40985 Reviewed-By: Antoine du Hamel <[email protected]>

Refs: #40985 (comment) PR-URL: #41176 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Refs: #40985 (comment) PR-URL: #41193 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>

PR-URL: nodejs#40985 Reviewed-By: Antoine du Hamel <[email protected]>

Refs: nodejs#40985 (comment) PR-URL: nodejs#41176 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Refs: nodejs#40985 (comment) PR-URL: nodejs#41193 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>

PR-URL: #40985 Reviewed-By: Antoine du Hamel <[email protected]>

Refs: #40985 (comment) PR-URL: #41176 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Refs: #40985 (comment) PR-URL: #41193 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>

Mesteery added the blocked PRs that are blocked by other issues or PRs. label Nov 26, 2021

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 26, 2021

Mesteery mentioned this pull request Nov 26, 2021

build: update actions file #39871

Closed

aduh95 reviewed Nov 27, 2021

View reviewed changes

.github/workflows/auto-start-ci.yml Outdated Show resolved Hide resolved

.github/workflows/commit-queue.yml Outdated Show resolved Hide resolved

aduh95 reviewed Nov 27, 2021

View reviewed changes

.github/workflows/commit-queue.yml Outdated Show resolved Hide resolved

aduh95 approved these changes Nov 27, 2021

View reviewed changes

Mesteery force-pushed the gh-cli-actions branch from 3e1979b to d402b17 Compare November 27, 2021 10:28

build: use gh cli in workflows file

9a6a818

Mesteery force-pushed the gh-cli-actions branch from d402b17 to 9a6a818 Compare November 27, 2021 10:30

Mesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 27, 2021

Mesteery removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 27, 2021

Mesteery added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed blocked PRs that are blocked by other issues or PRs. labels Dec 14, 2021

aduh95 reviewed Dec 14, 2021

View reviewed changes

.github/workflows/comment-labeled.yml Outdated Show resolved Hide resolved

Update .github/workflows/comment-labeled.yml

792b88f

Co-authored-by: Antoine du Hamel <[email protected]>

aduh95 approved these changes Dec 14, 2021

View reviewed changes

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Dec 14, 2021

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 14, 2021

nodejs-github-bot merged commit f404cd5 into nodejs:master Dec 14, 2021

Mesteery deleted the gh-cli-actions branch December 14, 2021 19:07

Mesteery added a commit to Mesteery/node that referenced this pull request Dec 14, 2021

build: fix comment-labeled workflow

f52a6b8

Refs: nodejs#40985 (comment)

Mesteery mentioned this pull request Dec 14, 2021

build: fix comment-labeled workflow #41176

Merged

ssua91 approved these changes Dec 15, 2021

View reviewed changes

Trott mentioned this pull request Dec 15, 2021

meta: move one or more collaborators to emeritus #41154

Merged

aduh95 added a commit to aduh95/node that referenced this pull request Dec 16, 2021

tools: fix `GitHub actions status when CQ is empty

14cf6bf

Refs: nodejs#40985 (comment)

aduh95 mentioned this pull request Dec 16, 2021

tools: fix `GitHub actions status when CQ is empty #41193

Merged

danielleadams pushed a commit that referenced this pull request Dec 16, 2021

build: use gh cli in workflows file

a18e886

PR-URL: #40985 Reviewed-By: Antoine du Hamel <[email protected]>

danielleadams mentioned this pull request Dec 16, 2021

v17.3.0 release proposal #41167

Merged

aduh95 added a commit to aduh95/node that referenced this pull request Dec 17, 2021

tools: fix GitHub Actions status when CQ is empty

2fb7aaf

Refs: nodejs#40985 (comment)

danielleadams pushed a commit that referenced this pull request Dec 17, 2021

build: use gh cli in workflows file

61c53a6

PR-URL: #40985 Reviewed-By: Antoine du Hamel <[email protected]>

nodejs-github-bot pushed a commit that referenced this pull request Dec 18, 2021

tools: fix GitHub Actions status when CQ is empty

587b167

Refs: #40985 (comment) PR-URL: #41193 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>

targos pushed a commit that referenced this pull request Jan 14, 2022

tools: fix GitHub Actions status when CQ is empty

c44185c

Refs: #40985 (comment) PR-URL: #41193 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>

danielleadams pushed a commit that referenced this pull request Jan 31, 2022

build: use gh cli in workflows file

e23d862

PR-URL: #40985 Reviewed-By: Antoine du Hamel <[email protected]>

danielleadams pushed a commit that referenced this pull request Jan 31, 2022

build: use gh cli in workflows file

19f8b48

PR-URL: #40985 Reviewed-By: Antoine du Hamel <[email protected]>

danielleadams pushed a commit that referenced this pull request Jan 31, 2022

tools: fix GitHub Actions status when CQ is empty

4bc5efe

Refs: #40985 (comment) PR-URL: #41193 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>

Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022

build: use gh cli in workflows file

1b04f4f

PR-URL: nodejs#40985 Reviewed-By: Antoine du Hamel <[email protected]>

Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022

tools: fix GitHub Actions status when CQ is empty

7e09f5a

Refs: nodejs#40985 (comment) PR-URL: nodejs#41193 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>

danielleadams pushed a commit that referenced this pull request Feb 1, 2022

build: use gh cli in workflows file

7756e1c

PR-URL: #40985 Reviewed-By: Antoine du Hamel <[email protected]>

danielleadams pushed a commit that referenced this pull request Feb 1, 2022

tools: fix GitHub Actions status when CQ is empty

95568dc

Refs: #40985 (comment) PR-URL: #41193 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>

danielleadams mentioned this pull request Feb 1, 2022

v16.14.0 proposal #41804

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: use gh cli in workflows file #40985

build: use gh cli in workflows file #40985

Mesteery commented Nov 26, 2021

Mesteery commented Nov 26, 2021

aduh95 left a comment

Mesteery commented Nov 27, 2021

aduh95 commented Nov 27, 2021

Mesteery commented Nov 27, 2021 •

edited

Loading

Mesteery commented Dec 14, 2021

nodejs-github-bot commented Dec 14, 2021

Trott commented Dec 14, 2021

Trott commented Dec 14, 2021

Mesteery commented Dec 14, 2021 •

edited

Loading

Trott commented Dec 15, 2021

build: use gh cli in workflows file #40985

build: use gh cli in workflows file #40985

Conversation

Mesteery commented Nov 26, 2021

Mesteery commented Nov 26, 2021

aduh95 left a comment

Choose a reason for hiding this comment

Mesteery commented Nov 27, 2021

aduh95 commented Nov 27, 2021

Mesteery commented Nov 27, 2021 • edited Loading

Mesteery commented Dec 14, 2021

nodejs-github-bot commented Dec 14, 2021

Trott commented Dec 14, 2021

Trott commented Dec 14, 2021

Mesteery commented Dec 14, 2021 • edited Loading

Trott commented Dec 15, 2021

Mesteery commented Nov 27, 2021 •

edited

Loading

Mesteery commented Dec 14, 2021 •

edited

Loading