Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: set --v8-enable-object-print by default #34705

Closed
wants to merge 1 commit into from
Closed

build: set --v8-enable-object-print by default #34705

wants to merge 1 commit into from

Conversation

mmarchini
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@mmarchini
build: set --v8-enable-object-print by default
3ef34d5 
The flag improves the experience of debugging V8 with native debuggers.
It doens't incur performance penality, the only downside is an increase
in binary size by approximately 248 Kb.

Ref: nodejs#32834
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Aug 10, 2020
@mmarchini mmarchini added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 10, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 10, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32700/

@gengjiawen
Copy link
Member

@mmarchini Do you want fast-track this and make it to 14.8.0 ?

@mmarchini
Copy link
Contributor Author

Better to let it sit on master for a bit (it shouldn't have any side effects, but still)

@mmarchini
Copy link
Contributor Author

Landed in b5e3fca

@mmarchini mmarchini closed this Aug 12, 2020
mmarchini added a commit that referenced this pull request Aug 12, 2020
@mmarchini
build: set --v8-enable-object-print by default
b5e3fca 
The flag improves the experience of debugging V8 with native debuggers.
It doens't incur performance penality, the only downside is an increase
in binary size by approximately 248 Kb.

Ref: #32834

PR-URL: #34705
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: David Carlier <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
@mmarchini @MylesBorins
build: set --v8-enable-object-print by default
75e3283 
The flag improves the experience of debugging V8 with native debuggers.
It doens't incur performance penality, the only downside is an increase
in binary size by approximately 248 Kb.

Ref: #32834

PR-URL: #34705
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: David Carlier <[email protected]>
@danielleadams danielleadams mentioned this pull request Aug 20, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
@mmarchini @BethGriggs
build: set --v8-enable-object-print by default
15c9208 
The flag improves the experience of debugging V8 with native debuggers.
It doens't incur performance penality, the only downside is an increase
in binary size by approximately 248 Kb.

Ref: #32834

PR-URL: #34705
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: David Carlier <[email protected]>
danielleadams pushed a commit that referenced this pull request Aug 25, 2020
2020-08-25, Version 14.9.0 (Current)
0cb4cbb 
Notable changes:

- build: set --v8-enable-object-print by default (Mary Marchini)
  [#34705](#34705)
- deps:
  - upgrade to libuv 1.39.0 (cjihrig)
    [#34915](#34915)
  - upgrade npm to 6.14.8 (Ruy Adorno)
    [#34834](#34834)
  - V8: cherry-pick e06ace6b5cdb (Anna Henningsen)
    [#34673](#34673)
- n-api: handle weak no-finalizer refs correctly (Gabriel Schulhof)
  [#34839](#34839)
- tools: add debug entitlements for macOS 10.15+ (Gabriele Greco)
  [#34378](#34378)

PR-URL: #34852
danielleadams pushed a commit that referenced this pull request Aug 26, 2020
2020-08-26, Version 14.9.0 (Current)
9f971f1 
Notable changes:

- build: set --v8-enable-object-print by default (Mary Marchini)
  [#34705](#34705)
- deps:
  - upgrade to libuv 1.39.0 (cjihrig)
    [#34915](#34915)
  - upgrade npm to 6.14.8 (Ruy Adorno)
    [#34834](#34834)
  - V8: cherry-pick e06ace6b5cdb (Anna Henningsen)
    [#34673](#34673)
- n-api: handle weak no-finalizer refs correctly (Gabriel Schulhof)
  [#34839](#34839)
- tools: add debug entitlements for macOS 10.15+ (Gabriele Greco)
  [#34378](#34378)

PR-URL: #34852
danielleadams pushed a commit that referenced this pull request Aug 26, 2020
2020-08-26, Version 14.9.0 (Current)
cc595f2 
Notable changes:

- build: set --v8-enable-object-print by default (Mary Marchini)
  [#34705](#34705)
- deps:
  - upgrade to libuv 1.39.0 (cjihrig)
    [#34915](#34915)
  - upgrade npm to 6.14.8 (Ruy Adorno)
    [#34834](#34834)
  - V8: cherry-pick e06ace6b5cdb (Anna Henningsen)
    [#34673](#34673)
- n-api: handle weak no-finalizer refs correctly (Gabriel Schulhof)
  [#34839](#34839)
- tools: add debug entitlements for macOS 10.15+ (Gabriele Greco)
  [#34378](#34378)

PR-URL: #34852
danielleadams pushed a commit that referenced this pull request Aug 26, 2020
2020-08-27, Version 14.9.0 (Current)
7f7d428 
Notable changes:

- build: set --v8-enable-object-print by default (Mary Marchini)
  [#34705](#34705)
- deps:
  - upgrade to libuv 1.39.0 (cjihrig)
    [#34915](#34915)
  - upgrade npm to 6.14.8 (Ruy Adorno)
    [#34834](#34834)
  - V8: cherry-pick e06ace6b5cdb (Anna Henningsen)
    [#34673](#34673)
- n-api: handle weak no-finalizer refs correctly (Gabriel Schulhof)
  [#34839](#34839)
- tools: add debug entitlements for macOS 10.15+ (Gabriele Greco)
  [#34378](#34378)

PR-URL: #34852
danielleadams pushed a commit that referenced this pull request Aug 27, 2020
2020-08-27, Version 14.9.0 (Current)
3153c2d 
Notable changes:

- build: set --v8-enable-object-print by default (Mary Marchini)
  [#34705](#34705)
- deps:
  - upgrade to libuv 1.39.0 (cjihrig)
    [#34915](#34915)
  - upgrade npm to 6.14.8 (Ruy Adorno)
    [#34834](#34834)
  - V8: cherry-pick e06ace6b5cdb (Anna Henningsen)
    [#34673](#34673)
- n-api: handle weak no-finalizer refs correctly (Gabriel Schulhof)
  [#34839](#34839)
- tools: add debug entitlements for macOS 10.15+ (Gabriele Greco)
  [#34378](#34378)

PR-URL: #34852
BethGriggs pushed a commit that referenced this pull request Aug 27, 2020
@BethGriggs
2020-08-27, Version 14.9.0 (Current)
3089f96 
Notable changes:

- build: set --v8-enable-object-print by default (Mary Marchini)
  [#34705](#34705)
- deps:
  - upgrade to libuv 1.39.0 (cjihrig)
    [#34915](#34915)
  - upgrade npm to 6.14.8 (Ruy Adorno)
    [#34834](#34834)
  - V8: cherry-pick e06ace6b5cdb (Anna Henningsen)
    [#34673](#34673)
- n-api: handle weak no-finalizer refs correctly (Gabriel Schulhof)
  [#34839](#34839)
- tools: add debug entitlements for macOS 10.15+ (Gabriele Greco)
  [#34378](#34378)

PR-URL: #34852
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@mmarchini @addaleax
build: set --v8-enable-object-print by default
8bce3b7 
The flag improves the experience of debugging V8 with native debuggers.
It doens't incur performance penality, the only downside is an increase
in binary size by approximately 248 Kb.

Ref: #32834

PR-URL: #34705
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: David Carlier <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@mmarchini @addaleax
build: set --v8-enable-object-print by default
380600d 
The flag improves the experience of debugging V8 with native debuggers.
It doens't incur performance penality, the only downside is an increase
in binary size by approximately 248 Kb.

Ref: #32834

PR-URL: #34705
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: David Carlier <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmarchini @nodejs-github-bot @gengjiawen @devnexen