Skip to content

Commit

Permalink
build: set --v8-enable-object-print by default
Browse files Browse the repository at this point in the history
The flag improves the experience of debugging V8 with native debuggers.
It doens't incur performance penality, the only downside is an increase
in binary size by approximately 248 Kb.

Ref: #32834

PR-URL: #34705
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: David Carlier <[email protected]>
  • Loading branch information
mmarchini authored and addaleax committed Sep 22, 2020
1 parent 45d712c commit 380600d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@
# Enable disassembler for `--print-code` v8 options
'v8_enable_disassembler': 1,

# Sets -dOBJECT_PRINT.
'v8_enable_object_print%': 1,

# https://github.com/nodejs/node/pull/22920/files#r222779926
'v8_enable_handle_zapping': 0,

Expand Down
2 changes: 1 addition & 1 deletion configure.py
Original file line number Diff line number Diff line change
Expand Up @@ -651,7 +651,7 @@
parser.add_option('--v8-enable-object-print',
action='store_true',
dest='v8_enable_object_print',
default=False,
default=True,
help='compile V8 with auxiliar functions for native debuggers')

parser.add_option('--node-builtin-modules-path',
Expand Down

0 comments on commit 380600d

Please sign in to comment.