build: set --v8-enable-object-print by default

The flag improves the experience of debugging V8 with native debuggers. It doens't incur performance penality, the only downside is an increase in binary size by approximately 248 Kb. Ref: #32834 PR-URL: #34705 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: David Carlier <[email protected]>
nodejs · Aug 20, 2020 · 15c9208 · 15c9208
1 parent 6ee2578
commit 15c9208
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/common.gypi b/common.gypi
@@ -54,6 +54,9 @@
     # Enable disassembler for `--print-code` v8 options
     'v8_enable_disassembler': 1,
 
+    # Sets -dOBJECT_PRINT.
+    'v8_enable_object_print%': 1,
+
     # https://github.com/nodejs/node/pull/22920/files#r222779926
     'v8_enable_handle_zapping': 0,
 

diff --git a/configure.py b/configure.py
@@ -662,7 +662,7 @@
 parser.add_option('--v8-enable-object-print',
     action='store_true',
     dest='v8_enable_object_print',
-    default=False,
+    default=True,
     help='compile V8 with auxiliar functions for native debuggers')
 
 parser.add_option('--node-builtin-modules-path',