Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix master branch build for Windows on Arm #33511

Closed

Conversation

richard-townsend-arm
Copy link
Contributor

Follow up to #32867, the new version of V8 (and new version of zlib) require a few definition fixups. After this, the master branch should build successfully for Windows on Arm.

CC @joaocgreis

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 22, 2020
@richardlau richardlau added arm Issues and PRs related to the ARM platform. build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels May 22, 2020
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

Change-Id: I011134f5680719e8fc246b8c660ececf0c596fd8
@richard-townsend-arm
Copy link
Contributor Author

Cool, so the possibly Win 7 breaking change is now gated behind a flag. CI flakes look spurious (they all fail on platforms that are unchanged). Ready for review. Once the change is adopted, I'll build and test the master branch daily and try to fix any failures as they arise.

@nodejs-github-bot
Copy link
Collaborator

@richard-townsend-arm
Copy link
Contributor Author

Cool, thanks for that - I don’t have permission to merge though.

Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 30, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 30, 2020

@BridgeAR
Copy link
Member

Landed in 99abaf9...ce025d9

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 30, 2020
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 30, 2020
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR BridgeAR closed this May 30, 2020
codebytere pushed a commit that referenced this pull request Jun 18, 2020
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: #33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
codebytere pushed a commit that referenced this pull request Jun 18, 2020
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: #33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@codebytere codebytere mentioned this pull request Jun 28, 2020
codebytere pushed a commit that referenced this pull request Jun 30, 2020
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: #33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
codebytere pushed a commit that referenced this pull request Jun 30, 2020
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: #33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@codebytere
Copy link
Member

@richard-townsend-arm this conflicts in a handful of places - could you please manually backport it to v12.x?

Trott pushed a commit to Trott/io.js that referenced this pull request Apr 14, 2021
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 14, 2021
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 14, 2021
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 14, 2021
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 16, 2021
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 16, 2021
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 16, 2021
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 16, 2021
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 16, 2021
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 16, 2021
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 16, 2021
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 16, 2021
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm Issues and PRs related to the ARM platform. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants