Skip to content

Commit

Permalink
build: fix GetCurrentThreadStackLimits error on Windows on Arm
Browse files Browse the repository at this point in the history
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
  • Loading branch information
richard-townsend-arm authored and Trott committed Apr 16, 2021
1 parent 3b9cf54 commit ce5e324
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions tools/v8_gypfiles/v8.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -1036,8 +1036,10 @@
'<(V8_ROOT)/src/base/platform/platform-win32.cc',
'<(V8_ROOT)/src/base/win32-headers.h',
],

'defines': ['_CRT_RAND_S'], # for rand_s()
'conditions': [['target_arch == "arm64"', {
'defines': ['_WIN32_WINNT=0x0602'], # For GetCurrentThreadStackLimits on Windows on Arm
}]],
'defines': ['_CRT_RAND_S'], # for rand_s()
'direct_dependent_settings': {
'msvs_settings': {
'VCLinkerTool': {
Expand Down

0 comments on commit ce5e324

Please sign in to comment.