-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
process: move more dependency of environment variables to pre-execution #26466
Conversation
Since we should treat the node-inspect as third-party user code.
Since it depends on environment variables.
Since this depends on environment variable, and the worker threads do not need to persist the variable value because they cannot switch cwd.
Landed in e029bc9...f617a73 |
Since we should treat the node-inspect as third-party user code. PR-URL: #26466 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Since it depends on environment variables. PR-URL: #26466 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Since this depends on environment variable, and the worker threads do not need to persist the variable value because they cannot switch cwd. PR-URL: #26466 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This breaks on v11. @joyeecheung I guess we should try to backport this to reduce other conflicts. Would you be so kind and have a look? |
The first commit and third commit seem fine but the warning handler breaks. The third relies on the second one though. |
I think this should land cleanly after #25685 is backported? |
Oh wait, this needs a non-semver-major form of #25828 as well |
Since we should treat the node-inspect as third-party user code. PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Since it depends on environment variables. PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Since this depends on environment variable, and the worker threads do not need to persist the variable value because they cannot switch cwd. PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
@ZYSzys do you know if the tests pass as well? If so, I'll remove the label. In that case it will be pulled in the next release. |
@BridgeAR Sadly tests weren't passed. This PR dependent on #25828(that was |
@ZYSzys thanks for checking again! |
PR to backport #26662 |
Since we should treat the node-inspect as third-party user code. PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Since it depends on environment variables. PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Since this depends on environment variable, and the worker threads do not need to persist the variable value because they cannot switch cwd. PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Since we should treat the node-inspect as third-party user code. PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Since it depends on environment variables. PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Since this depends on environment variable, and the worker threads do not need to persist the variable value because they cannot switch cwd. PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Since we should treat the node-inspect as third-party user code. Backport-PR-URL: nodejs#26662 PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Since it depends on environment variables. Backport-PR-URL: nodejs#26662 PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Since this depends on environment variable, and the worker threads do not need to persist the variable value because they cannot switch cwd. Backport-PR-URL: nodejs#26662 PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
process: call
prepareMainThreadExecution
innode inspect
Since we should treat the node-inspect as third-party
user code.
process: set up process warning handler in pre-execution
Since it depends on environment variables.
process: handle process.env.NODE_V8_COVERAGE in pre-execution
Since this depends on environment variable, and the worker threads
do not need to persist the variable value because they cannot
switch cwd.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes