process: set up process warning handler in pre-execution

Since it depends on environment variables. Backport-PR-URL: nodejs#26662 PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
targos · Mar 27, 2019 · cc606e2 · cc606e2
1 parent 03dba72
commit cc606e2
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 4 deletions.
diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
@@ -115,12 +115,9 @@ if (isMainThread) {
 }
 
 const {
-  onWarning,
   emitWarning
 } = NativeModule.require('internal/process/warning');
-if (!process.noProcessWarnings && process.env.NODE_NO_WARNINGS !== '1') {
-  process.on('warning', onWarning);
-}
+
 process.emitWarning = emitWarning;
 
 const {

diff --git a/lib/internal/bootstrap/pre_execution.js b/lib/internal/bootstrap/pre_execution.js
@@ -8,6 +8,8 @@ let traceEventsAsyncHook;
 function prepareMainThreadExecution() {
   setupTraceCategoryState();
 
+  setupWarningHandler();
+
   // Only main thread receives signals.
   setupSignalHandlers();
 
@@ -36,6 +38,15 @@ function prepareMainThreadExecution() {
   loadPreloadModules();
 }
 
+function setupWarningHandler() {
+  const {
+    onWarning
+  } = require('internal/process/warning');
+  if (!process.noProcessWarnings && process.env.NODE_NO_WARNINGS !== '1') {
+    process.on('warning', onWarning);
+  }
+}
+
 function initializeReport() {
   if (!getOptionValue('--experimental-report')) {
     return;
@@ -251,6 +262,7 @@ function loadPreloadModules() {
 }
 
 module.exports = {
+  setupWarningHandler,
   prepareMainThreadExecution,
   initializeDeprecations,
   initializeESMLoader,

diff --git a/lib/internal/main/worker_thread.js b/lib/internal/main/worker_thread.js
@@ -4,6 +4,7 @@
 // message port.
 
 const {
+  setupWarningHandler,
   initializeDeprecations,
   initializeESMLoader,
   initializeFrozenIntrinsics,
@@ -39,6 +40,8 @@ const {
 const publicWorker = require('worker_threads');
 const debug = require('util').debuglog('worker');
 
+setupWarningHandler();
+
 debug(`[${threadId}] is setting up worker child environment`);
 
 // Set up the message port and start listening