Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process: move more dependency of environment variables to pre-execution #26466

Closed
wants to merge 3 commits into from
Closed

process: move more dependency of environment variables to pre-execution #26466

wants to merge 3 commits into from

Commits on Mar 6, 2019

  1. process: call prepareMainThreadExecution in node inspect 

    Since we should treat the node-inspect as third-party
user code.
    @joyeecheung
    joyeecheung committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    bdbcd0f View commit details
    Browse the repository at this point in the history

  2. process: set up process warning handler in pre-execution 

    Since it depends on environment variables.
    @joyeecheung
    joyeecheung committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    0e97fa3 View commit details
    Browse the repository at this point in the history

  3. process: handle process.env.NODE_V8_COVERAGE in pre-execution 

    Since this depends on environment variable, and the worker threads
do not need to persist the variable value because they cannot
switch cwd.
    @joyeecheung
    joyeecheung committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    410c588 View commit details
    Browse the repository at this point in the history