V11.5.0 proposal #25102
Merged
V11.5.0 proposal #25102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #24801 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #24793 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
This commit reduces shared state by introducing scopes and block scoped variables. It also makes the monkey patching used by the test more robust. PR-URL: #24834 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Richard Lau <[email protected]>
This commit replaces a call to Number.isFinite() with a cheaper typeof check. The subsequent range checks ensure that the checked value is finite. PR-URL: #24836 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
The path module's assertPath() does exactly what the validateString() validator does, so this commit updates path to use validateString() instead. A couple drive by updates to validateString() outside of assertPath() are also included. PR-URL: #24840 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Currently the following compiler warnings are generated:
../src/node_util.cc:59:16:
warning: unused variable 'env' [-Wunused-variable]
Environment* env = Environment::GetCurrent(args);
^
../src/node_util.cc:78:16:
warning: unused variable 'env' [-Wunused-variable]
Environment* env = Environment::GetCurrent(args);
^
2 warnings generated.
This commit removes the two unused variables.
PR-URL: #24820
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This commit removes the finalized_ member from the Hash class as it does not seem to be used in any valuable way. Commit c75f87c ("crypto: refactor the crypto module") removed the check where it was previously used. PR-URL: #24822 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Revise the Waiting for Approvals section of the Collaborator Guide. Keep sentences short and clear. Split long paragraphs into shorter paragraphs. PR-URL: #24845 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
PR-URL: #24799 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
PR-URL: #24791 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #24797 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #24798 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
gcc 8+ recognizes that space has not been left for the pid and that the return value of snprintf() isn't checked. Leave a little space for the pid to prevent `-Wformat-truncation`. PR-URL: #24810 Reviewed-By: Richard Lau <[email protected]>
In recent gcc, -Wrestrict warns when an argument passed to a restrict-qualified parameter aliases with another argument. PR-URL: #24810 Reviewed-By: Richard Lau <[email protected]>
Update the `LICENSE` file by running `tools/license-builder.sh`. PR-URL: #24898 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #24779 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
* Check for custom Node.js code rather than constructor in assert.throws(). * Use arrow functions consistently. PR-URL: #24859 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #24844 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Instead of using magic values for the server timeout in test-http2-session-timeout, measure the duration of the first request (which should be longer than subsequent requests) and use that value. Fixes: #20628 PR-URL: #24877 Fixes: #20628 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
A fix to test-http2-session-timeout makes it sufficiently robust that it can be moved to the parallel directory. PR-URL: #24877 Fixes: #20628 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
It is unreliable under load and the CI failures are getting a bit out of hand. Let's move it to sequential. Refs: #24403 PR-URL: #24907 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
For new Agent() signature in http doc, list the supported options in socket.connect(). Refs: #24098 PR-URL: #24846 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Instead of using a shared pointer of the entire debug option set,
pass the parsed debug option to inspector classes by value because
they are set once the CLI argument parsing is done. Add another shared
pointer to HostPort being used by the inspector server, which is copied
from the one in the debug options initially. The port of the shared
HostPort is 9229 by default and can be specified as 0 initially but
will be set to the actual port of the server once it starts listening.
This makes the shared state clearer and makes it possible to use
`require('internal/options')` in JS land to query the CLI options
instead of using `process._breakFirstLine` and other underscored
properties of `process` since we are now certain that these
values should not be altered once the parsing is done and can be
passed around in copies without locks.
PR-URL: #24772
Reviewed-By: Anna Henningsen <[email protected]>
Compiler version tuples should be numeric for tuple comparisons to work. Also correct check for AIX where the minimum supported GCC is 6.3.0 PR-URL: #24879 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
In case of an error where we only care about a cleaned up stack trace it is cheaper to reset the stack trace limit for the error that is created. That way the stack frames do not have to be computed twice. PR-URL: #24747 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
PR-URL: #24863 Refs: #22101 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Update "Testing and CI" in the Collaborator Guide. Remove redundant material. Shorten sentences. Remove incorrect material. (Specifically, we don't require test cases to be included in all pull requests that modify exectuable code. For example, if code is refactored, then passing existing tests is sufficient.) PR-URL: #24884 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #24882 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
The label should be applied early on. Otherwise there is little benefit using this label at all. PR-URL: #24893 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Update ESLint to 5.10.0. PR-URL: #24903 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
nodejs-github-bot
added
build
BethGriggs
force-pushed
the
v11.5.0-proposal
branch
from
3b184b5 to
c911de2
Compare
BethGriggs
added a commit
that referenced
this pull request
Dec 18, 2018
Notable changes:
* **test**:
* test TLS client authentication (Sam Roberts)
[#24733](#24733)
* **tls**:
* support "BEGIN TRUSTED CERTIFICATE" for ca: (Sam Roberts)
[#24733](#24733)
* **tools**:
* update ESLint to 5.10.0 (cjihrig)
[#24903](#24903)
* **util**:
* add inspection getter option (Ruben Bridgewater)
[#24852](#24852)
PR-URL: #25102
|
I don't think #24903 should be listed as notable. It's an internal tooling update and does not affect end users at all. |
|
I think the test portion of #24733 can be dropped from the notable changes as well |
|
Failing tst is parallel/test-process-release |
richardlau
reviewed
Dec 18, 2018
MylesBorins
force-pushed
the
v11.5.0-proposal
branch
from
c911de2 to
3a4c67d
Compare
MylesBorins
pushed a commit
that referenced
this pull request
Dec 18, 2018
Notable changes:
* **test**:
* test TLS client authentication (Sam Roberts)
[#24733](#24733)
* **tls**:
* support "BEGIN TRUSTED CERTIFICATE" for ca: (Sam Roberts)
[#24733](#24733)
* **tools**:
* update ESLint to 5.10.0 (cjihrig)
[#24903](#24903)
* **util**:
* add inspection getter option (Ruben Bridgewater)
[#24852](#24852)
PR-URL: #25102
|
Fixed the issue with CI: https://ci.nodejs.org/job/node-test-pull-request/19643/ ✅ Edit(@targos): CITGM on v11.x for comparison: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1693/ |
|
CITGM looks good |
BethGriggs
force-pushed
the
v11.5.0-proposal
branch
from
3a4c67d to
f45d41d
Compare
BethGriggs
force-pushed
the
v11.5.0-proposal
branch
from
f45d41d to
9a5b243
Compare
BethGriggs
added a commit
that referenced
this pull request
Dec 18, 2018
BethGriggs
added a commit
to BethGriggs/nodejs.org
that referenced
this pull request
Dec 18, 2018
BethGriggs
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Dec 18, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Notable changes:
* **tls**:
* support "BEGIN TRUSTED CERTIFICATE" for ca: (Sam Roberts)
[nodejs#24733](nodejs#24733)
* **util**:
* add inspection getter option (Ruben Bridgewater)
[nodejs#24852](nodejs#24852)
PR-URL: nodejs#25102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2018-12-18, Version 11.5.0 (Current), @BethGriggs
Notable Changes
Commits
bf4faf3ffc] - assert,util: harden comparison (Ruben Bridgewater) #24831302081bafc] - build: make lint-addon-docs run only if needed (Daniel Bevenius) #24993cc8a805e31] - build: fix compiler version detection (Richard Lau) #24879bde5df20d6] - doc: fix node.1 --http-parser sort order (cjihrig) #25045a9f239fb60] - doc: add EventTarget link to worker_threads (Azard) #2505800ce972305] - doc: make README formatting more consistent (wenjun ye) #25003dbdea36190] - doc: add codebytere's info to release team (Shelley Vohr) #25022877f8a0094] - doc: revise internal vs. public API in Collaborator Guide (Rich Trott) #24975f0bcacdcc6] - doc: update a link of npm repository (Daijiro Wachi) #249691e096291d6] - doc: fix author-ready conflict (Ruben Bridgewater) #25015b2e6cbddd8] - doc: update Useful CI Jobs section of Collaborator Guide (Rich Trott) #249169bfbb6822b] - doc: add class worker documentation (yoshimoto koki) #248490220cd3260] - doc: remove bad link to irc info (Richard Lau) #24967a6a3829962] - doc: simplify author ready (Ruben Bridgewater) #24893cda1da9200] - doc: update "Testing and CI" in Collaborator Guide (Rich Trott) #2488481dce68a9d] - doc: update http doc for new Agent()/support options in socket.connect() (Beni von Cheni) #24846643ca14d2c] - doc: fix order of events when request is aborted (Luigi Pinca) #24779c300aaa208] - doc: update LICENSE file (Anna Henningsen) #24898c4f3cf9759] - doc: revise Waiting for Approvals documentation (Rich Trott) #2484556b2a7274c] - inspector: split the HostPort being used and the one parsed from CLI (Joyee Cheung) #247722456a545a6] - lib: ensure readable stream flows to end (Mikko Rantanen) #2491879c52a9f88] - lib: improve error creation performance (Ruben Bridgewater) #2474725dae6cffd] - module: use validateString in modules/esm (ZYSzys) #248682a11e6aaf3] - module: use validateString in modules/cjs (ZYSzys) #24863f4d5c358d9] - net: use strict comparisons for fd (cjihrig) #250145f60ed7647] - path: replace assertPath() with validator (cjihrig) #24840f43f45a26c] - process: properly close file descriptor on exit (Ruben Bridgewater) #249728b109f05d9] - process: simplify check in previousValueIsValid() (cjihrig) #248362e94f3b798] - querystring: remove eslint-disable (cjihrig) #249955f8950b652] - src: emit 'params' instead of 'data' for NodeTracing.dataCollected (Kelvin Jin) #24949d0270f3a5c] - src: add GetLoadedLibraries routine (Gireesh Punathil) #24825f8547019c7] - src: include node_internals.h in node_metadata.cc (Daniel Bevenius) #249335a1289d128] - src: create env->inspector_console_api_object earlier (Joyee Cheung) #24906d7605725df] - src: remove use of CallOnForegroundThread() (cjihrig) #2492508c6b2126c] - src: use Local version of ToBoolean() (cjihrig) #249245206f3add5] - src: do not alias new and old signal masks (Sam Roberts) #2481094d02cabb9] - src: fix warning for potential snprintf truncation (Sam Roberts) #248109b000e5088] - src: remove finalized_ member from Hash class (Daniel Bevenius) #2482290d481ea45] - src: remove unused env variables in node_util (Daniel Bevenius) #24820d449c36500] - stream: re-use existingonce()implementation (Anna Henningsen) #2499139af61faa2] - stream: fix end-of-stream for HTTP/2 (Anna Henningsen) #249264f0d17b019] - test: remove unnecessary linter comment (cjihrig) #25013ab1801b8ad] - test: use global.gc() instead of gc() (cjihrig) #25012ddff644172] - test: run eslint on test file and fix errors (Ruben Bridgewater) #25009110fd39dfe] - test: remove dead code (Ruben Bridgewater) #25009e04e85460f] - test: use blocks instead of async IIFE (Anna Henningsen) #24989eb9e6e6576] - test: adding history regression test case (Anto Aravinth) #24843ac919efbaf] - test: mark test-child-process-execfile flaky (Rich Trott) #250511e3fb0ae03] - test: mark test-child-process-exit-code flaky (Rich Trott) #250507e0dbc6e01] - test: improve WPT runner name matching (Joyee Cheung) #24826da984be0a3] - test: remove reference to whatwg in file names under test/wpt (Joyee Cheung) #24826282589456c] - test: mark test-worker-memory flaky on Windows CI (Rich Trott) #250429bd42671c9] - test: mark test-cli-node-options flaky on arm (Rich Trott) #25032a4ef54a0a6] - test: mark test-child-process-execsync flaky on AIX (Rich Trott) #25031900a412f3f] - test: increase error information in test-cli-syntax-* (Rich Trott) #25021d5b0ce15d3] - test: refactor test-enable-in-init (Mitch Hankins) #24976649a7289dc] - test: from functools import reduce in test/testpy/__init__.py (cclauss) #24954d366676cc5] - test: split test-cli-syntax into multiple tests (Rich Trott) #24922e61bbda85d] - test: improve internet/test-dns (Ilarion Halushka) #24927016e35210c] - (SEMVER-MINOR) test: test TLS client authentication (Sam Roberts) #24733e050a5756f] - test: replace callback with arrows (Shubham Urkade) #2486622b6befa14] - test: mark test-cli-syntax as flaky/unreliable (Rich Trott) #2495756fd127ef0] - test: do not lint macros files (again) (cclauss) #24886bc71e9e0d6] - test: prepare test/pseudo-tty/testcfg.py Python 3 (cclauss) #24887f41443cc5c] - test: move test-cli-syntax to sequential (Rich Trott) #24907592bad1b0b] - test: move http2 test to parallel (Rich Trott) #2487791ce957037] - test: make http2 timeout test robust (Rich Trott) #248773d87688fba] - test: fix wrong parameter (zhmushan) #248446db760c231] - test: improve test-net-socket-timeout (Rich Trott) #24859526ff1d1d2] - test: prepare test/pseudo-tty/testcfg.py for Python 3 (cclauss) #24791a5c57861a9] - test: refactor test-fs-write-file-sync.js (cjihrig) #24834a5c8af7af4] - test: prepare test/message/testcfg.py for Python 3 (cclauss) #24793390e050ae0] - (SEMVER-MINOR) tls: support "BEGIN TRUSTED CERTIFICATE" for ca: (Sam Roberts) #2473316a75beffc] - tools: prepare ./tools/compress_json.py for Python 3 (cclauss) #24889b60808a2da] - tools: prepare tools/testp.py for Python 3 (cclauss) #248901f61c89a7f] - tools: prepare tools/icu/icutrim.py for Python 3 (cclauss) #24888e140d41789] - tools: capitalize sentences (Ruben Bridgewater) #24808ad6104dbac] - tools: update ESLint to 5.10.0 (cjihrig) #24903ac46e27714] - tools: do not lint tools/inspector_protocol or tools/markupsafe (cclauss) #24882c3dda00e48] - tools: prepare tools/js2c.py for Python 3 (cclauss) #247987cac76cdd5] - tools: prepare tools/specialize_node_d.py for Python 3 (cclauss) #2479715632c3867] - tools: prepare tools/test.py for Python 3 (cclauss) #24799022599c0e1] - tools: prepare tools/genv8constants.py for Python 3 (cclauss) #24801e7b77ead74] - url: remove an eslint-disable comment (cjihrig) #2499559317470e3] - util: inspect all prototypes (Ruben Bridgewater) #24974a1f0da1d40] - util: remove todo (Ruben Bridgewater) #24982117e99121c] - (SEMVER-MINOR) util: add inspection getter option (Ruben Bridgewater) #24852331f6044b9] - worker: drain messages from internal message port (Yael Hermon) #24932